Firefox crashes when using the Accessibility Inspector on the browser mozilla::a11y::HyperTextAccessible::NativeRole]
Categories
(Core :: Disability Access APIs, defect, P1)
Tracking
()
People
(Reporter: atrif, Assigned: Jamie)
Details
(Keywords: crash, regressionwindow-wanted)
Crash Data
Attachments
(2 files)
3.84 MB,
image/gif
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- Firefox 70.0a1 (20190722214346)
- Firefox 69.0b7 (20190722201635)
Affected platforms
- Windows 10x64
Steps to reproduce
- Launch Firefox with a new profile and open Browser Tools (Ctrl+ Shift+ C).
- Enable browser toolbox.
- Open the browser toolbox.
- Select Accessibility in the toolbar and the Accessibility Inspector.
- Continuously move the pointer over Browser Tools (Inspector, Console, Debugger, etc.).
Expected result
- Firefox doesn't crash.
Actual result
- Firefox crashes at mozilla::a11y::HyperTextAccessible::NativeRole : https://crash-stats.mozilla.org/report/index/90a4b865-a3f9-47c2-961b-068050190723#tab-details.
Additional Notes
- Cannot search for regression range due to bug 1564542.
- I cannot reproduce the issue on macOS 10.14 or Ubuntu 18.04.
- Note that the issue may be intermittent.
- Attached a screen recording with the issue.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
On Windows, OuterDocAccessible::GetChildAt can return a proxy wrapper for a remote document.
These aren't real Accessibles and shouldn't be returned except to the Windows a11y code (which doesn't use eDeepestChild).
Calling ChildAtPoint on these will crash!
Therefore, just return null in this case.
Assignee | ||
Comment 2•5 years ago
|
||
Alexandru, is there any chance you might be able to test this with the following try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e457854c6f26079fbd8d6e3b08808987bf0aaf7a
I'm a blind screen reader user, so I can't use a mouse effectively, which makes it impossible for me to test this. However, I believe I've fixed the bug in this build. Thanks!
Reporter | ||
Comment 3•5 years ago
|
||
Hello James,
I tested with the provided build on Windows 10x64 following the steps from comment 0 moving the mouse pointer several times across browser and browser tools and no crashes were encountered while doing that. I even created new profiles and retested again and I cannot reproduce the crash anymore. If there is anything I can help with please let me know. Thank you!
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f39ed95662a Don't return proxy wrappers from OuterDocAccessible::ChildAtPoint with eDeepestChild to prevent crashes when hit testing via XPCOM. r=yzen
Comment 5•5 years ago
|
||
bugherder |
Reporter | ||
Comment 6•5 years ago
|
||
Hello!
The issue is verified fixed on Windows 10x64 with Firefox 70.0a1 (20190725215157). No crashes occur while doing the steps from comment 0.
Assignee | ||
Comment 7•5 years ago
|
||
Comment on attachment 9080236 [details]
Bug 1568163: Don't return proxy wrappers from OuterDocAccessible::ChildAtPoint with eDeepestChild to prevent crashes when hit testing via XPCOM.
Beta/Release Uplift Approval Request
- User impact if declined: Crashes on Windows when moving the mouse over the browser after enabling the Accessibility Inspector in the Browser Toolbox.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial fix which affects a very specific code path only engaged (outside of tests) when using the Accessibility Inspector in the Browser Toolbox on Windows.
- String changes made/needed: None.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Comment on attachment 9080236 [details]
Bug 1568163: Don't return proxy wrappers from OuterDocAccessible::ChildAtPoint with eDeepestChild to prevent crashes when hit testing via XPCOM.
Fixes a crash with the Accessibility Inspector. Approved for 69.0b9.
Comment 9•5 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 10•5 years ago
|
||
Hello,
The issue is verified fixed using Firefox 69.0b9 (20190726195447) on Windows 10x64. Thank you!
Description
•