Closed
Bug 1568175
Opened 6 years ago
Closed 6 years ago
Simplify "availableLocales" functions by directly using CallArgs::rval
Categories
(Core :: JavaScript: Internationalization API, task)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
FIXED
mozilla70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
From js::intl_Collator_availableLocales
RootedValue result(cx);
if (!GetAvailableLocales(cx, ucol_countAvailable, ucol_getAvailable, &result)) {
return false;
}
args.rval().set(result);
return true;
can be simplified to:
return GetAvailableLocales(cx, ucol_countAvailable, ucol_getAvailable, args.rval());
The same pattern appears in all Intl classes.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0759132b55b8e5717cf82f21d1c0428a5360448
Keywords: checkin-needed
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9cca1ac4fe97
Directly store result of 'available-locales' function in args.rval(). r=khyperia
Keywords: checkin-needed
Comment 4•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•