1568216 - Rework/Improve PiP context menu options

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, enhancement, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Video of Size and Move

Affected versions:
70.0a1 (2019-07-23) (64-bit)
69.0b6 (64-bit)

Affected platforms:
Windows 7/10

Steps to reproduce:

• Launch Nightly or Beta
• Go to any video, such as youtube: https://www.youtube.com/watch?v=IoinmjCmM-E
• Click on the PIP toggle button
• Right click on the PiP window

Expected result:
There is nothing clearly defined about what options should the PiP context menu contain and the expect

Actual Result:
The following PiP context menu options:

• Restore - this is grayed out unless the PiP window is made full-screen. Users might understand this option as a "restore the PiP window back to the tab where it belongs"
• Move and Size - both have the same incorrect functionality, check screen recording
• Minimize - will move the PiP window in the task-bar
• Maximize - will turn the PiP window into full-screen
• Close- closes the PiP window

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1568216 - Disable context menu for Picture-in-Picture player window. r?JSON_Voorhees

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ba817e4d1bd
Disable context menu for Picture-in-Picture player window. r=JSON_voorhees

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9ba817e4d1bd

Comment 4

[Cristian Craciun]

Build ID 20191027212548
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Verified as fixed on the latest Nightly build on Windows 7.