Closed Bug 1568230 Opened 5 years ago Closed 5 years ago

Better server response handling in Monitor card

Categories

(Firefox :: Protections UI, task, P1)

Product:
Firefox
Component:
Protections UI
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: mtigley, Assigned: mtigley)

References

Details

(Whiteboard: [skyline])

Attachments

(1 file)

Bug 1568230 - Handle 401 server responses when fetching breach stats.
47 bytes, text/x-phabricator-request
Details | Review

In Bug 1559424 we added a verification layer for handling server errors from the Monitor endpoint. However, for completeness and future-proofing the code we should also consider adding these additional checks:

  • Check that if response.status === 401 we throw an error for an INVALID_OAUTH_TOKEN. Currently, we only check for 400, but this is probably an issue in FxA that will be fixed, so our client needs to be able to handle it.
  • Handle any errors that may be thrown from using fxAccounts.getOAuthToken
Priority: -- → P1
Whiteboard: [skyline]
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0aa7c9007c3
Handle 401 server responses when fetching breach stats. r=rfkelly

https://hg.mozilla.org/mozilla-central/rev/b0aa7c9007c3

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: