1568246 - Exceptions button still clickable when popup policy is locked

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Mike Kaply [:mkaply]]

When you lock the popup policy, it should lock the Exceptions button.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1568246 - Disable Exceptions button if popup pref is locked.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2ef26ada52c
Disable Exceptions button if popup pref is locked. r=jaws

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a2ef26ada52c

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9080086 [details]
Bug 1568246 - Disable Exceptions button if popup pref is locked.

Beta/Release Uplift Approval Request

• User impact if declined: Button is enabled even though policy says it shouldn't be
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Set popup policy and lock it. Verify button is locked.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a new check specific to preference locking.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to make policy look like it is working correctly.
• User impact if declined: Button is enabled even though policy says it shouldn't
• Fix Landed on Version: 70
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a new check specific to preference locking.
• String or UUID changes made by this patch:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9080086 [details]
Bug 1568246 - Disable Exceptions button if popup pref is locked.

Minor fix to ensure that a button isn't enabled when it's disabled by policy. Approved for 69.0b9 and 68.1esr.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/50f29c924e44

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/8a2ec3fcd685

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

Tested on macOS 10.11, windows 10 x64 and Ubuntu 18.04 using Firefox 70.0a1, Firefox 68.0ESR (intermediary build) and Firefox 69.0b9 (intermediary build).

Please note that while the exceptions button is not accessible, the policy can still be bypassed. See 1569623 for more details.