1568323 - [wpt-sync] Sync PR 18012 - Update webxr_test_asserts and align xr layout_tests usage of asserts

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 18012 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18012
Details from upstream follow.

Alex Cooper <[e-mail]> wrote:

Update webxr_test_asserts and align xr layout_tests usage of asserts

Updates webxr_test_asserts with chromium's more verbose asserts for
easier debugging of tests, and removes the asserts from xr-test-utils
so that all asserts can be referenced from webxr_test_asserts.

Bug:985156
Change-Id: Ie8d2ca70dd18a7e1759fe2b4d83b02076fcf91c0
Reviewed-on: https://chromium-review.googlesource.com/1715916
WPT-Export-Revision: ea30a16e905957d6a5cab4e29aed1c88874c33ce

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef8e1e76ff2a6ea20d85a8ffe6f90bf6aedc8391

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d5125124703a868661cb95e2474c79772889058

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 12 tests and 17[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] subtests
OK     : 12[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]
FAIL   : 17[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt]

Tests that are disabled for instability:
/webxr/getInputPose_pointer.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrBoundedReferenceSpace_updates.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrFrame_getPose.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrRay_constructor.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrRay_matrix.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrReferenceSpace_originOffset.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrReferenceSpace_originOffsetBounded.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrRigidTransform_matrix.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrStationaryReferenceSpace_floorlevel_updates.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrView_eyes.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
/webxr/xrWebGLLayer_viewports.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcbb3ce00788
[wpt PR 18012] - Update webxr_test_asserts and align xr layout_tests usage of asserts, a=testonly

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/fcbb3ce00788