Closed Bug 1568352 Opened 5 years ago Closed 5 years ago

AuthStateProvider: add Fenix Nightly to a list of trusted consumers

Categories

(Firefox for Android Graveyard :: Firefox Accounts, enhancement)

Product:
Firefox for Android Graveyard
Component:
Firefox Accounts
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr6869+ fixed, firefox68 wontfix, firefox69 fixed, firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr68 69+ fixed
firefox68 --- wontfix
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

Attachments

(2 files)

Bug 1568352 - Add Firefox Preview Nightly to AuthStateProvider's whitelist r=nalexander
47 bytes, text/x-phabricator-request
Details | Review
auth_state_fenix_nightly.patch
2.19 KB, patch
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-esr68+
Details | Diff | Splinter Review

We will soon publish a Fenix Nightly in a new Play Store channel, which means it will have a different app ID. Let's add it to the whitelist of trusted applications to speed up testing of this functionality.

Blocks: 1545232
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7df14177b8de
Add Firefox Preview Nightly to AuthStateProvider's whitelist r=nalexander

https://hg.mozilla.org/mozilla-central/rev/7df14177b8de

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Beta/Release Uplift Approval Request

  • User impact if declined: Fenix Nightly channel will be unable to use AuthStateProvider.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky; we're simply adding another mozilla-owned product to the whitelist of applications allowed to access the AuthStateProvider.
  • String changes made/needed: N/A
Attachment #9081805 - Flags: approval-mozilla-beta?
Attachment #9080198 - Flags: approval-mozilla-beta?

69=affected because Grisha would like to uplift this fix to GeckoView 69 Beta for Fenix.
68=wontfix because we don't need to uplift this Fenix fix to Fennec ESR 68.

status-firefox68: --- → wontfix
status-firefox69: --- → affected
status-firefox-esr68: --- → wontfix

Let's uplift this to ESR68 - my bad, I should have made this clearer. This fix lives in Fennec actually, not GeckoView, so it needs to be part of ESR68 for Fenix Nightly to benefit from it.

Flags: needinfo?(cpeterson)
Attachment #9080198 - Flags: approval-mozilla-beta?
Comment on attachment 9081805 [details] [diff] [review]
auth_state_fenix_nightly.patch

Whitelists Fenix Nightly so it can access AuthStateProvider. Approved for GV69 and Fennec 68.1b5.
Flags: needinfo?(cpeterson)
Attachment #9081805 - Flags: approval-mozilla-esr68+
Attachment #9081805 - Flags: approval-mozilla-beta?
Attachment #9081805 - Flags: approval-mozilla-beta+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: