1568499 - Check if we could merge WebConsole, WebConsoleUI and WebConsoleWrapper

Status: NEW

(DevTools :: Console, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Here's the current state of the webconsole panel hierarchy:

• WebConsolePanel has a hud property, which is a WebConsole instance
• WebConsole has a ui property which is a WebConsoleUI instance
• WebConsoleUI has a wrapper property which is a WebConsoleWrapper instance
• WebConsoleWrapper renders the React app

If seems like we could collapse WebConsole, WebConsoleUI and WebConsoleWrapper, as it's unclear why each of these are separated.

This is probably a relic of ancient time when we transitioned to the new console frontend.
Everything could be under the WebConsole (and the BrowserConsole, which extends BrowserConsole), making the code easier to follow.

This could also help clarify some of our interaction and methods, which are often only piping things to other instance methods.

Comment 1

[Alexandre Poirot [:ochameau]]

Big +1! A side effect would be that we would no longer have "hud", which is very cryptic and doesn't help understanding that it is actually a reference to WebConsole/BrowserConsole!
If that's any helpful, we could start with merging just WebConsole/BrowserConsole and WebConsoleUI, so that at least, we no longer have this hud thing.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Also to note while we fix this https://phabricator.services.mozilla.com/D99623#inline-570493