Closed Bug 1568536 Opened 2 years ago Closed 2 years ago

Don't propagate viewport styles for boxless elements.

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(2 files)

Return a raw pointer instead of a strong reference to a ComputedStyle, and
handle the case of the style not being present by returning null rather than
requiring an extra function to check it and crashing if the precondition is not
met.

Also, name them so that it's clear they just return outdated styles and don't
make any extra effort.

This is just cleanup that makes the next patch easier / more obvious.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/778ea34e5994
Simplify some style system APIs. r=heycam
https://hg.mozilla.org/integration/autoland/rev/400b06aac33e
Don't propagate viewport styles from display: none or display: contents elements. r=dholbert
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.