1568536 - Don't propagate viewport styles for boxless elements.

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Per https://github.com/w3c/csswg-drafts/issues/3779#issuecomment-481762912

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1568536 - Don't propagate viewport styles from display: none or display: contents elements. r=dholbert

Resolution is at:

• https://github.com/w3c/csswg-drafts/issues/3779#issuecomment-481762912

Tests are at https://chromium-review.googlesource.com/c/chromium/src/+/1547974,
I'll make sure to wait until they're in the tree and ensure they're passing.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1568536 - Simplify some style system APIs. r=dholbert

Return a raw pointer instead of a strong reference to a ComputedStyle, and
handle the case of the style not being present by returning null rather than
requiring an extra function to check it and crashing if the precondition is not
met.

Also, name them so that it's clear they just return outdated styles and don't
make any extra effort.

This is just cleanup that makes the next patch easier / more obvious.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/778ea34e5994
Simplify some style system APIs. r=heycam
https://hg.mozilla.org/integration/autoland/rev/400b06aac33e
Don't propagate viewport styles from display: none or display: contents elements. r=dholbert

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/778ea34e5994
https://hg.mozilla.org/mozilla-central/rev/400b06aac33e