1568546 - Self-hosting werror + extraWarnings can cause browser crashes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jan de Mooij [:jandem]]

In FillSelfHostingCompileOptions we set werrorOption = true unconditionally but extraWarningsOption = true only in DEBUG builds. This can cause weird crashes if people enable javascript.options.strict. Bug 1567902 is one instance of this but to fix the root cause we should either:

1. Set options.werrorOption = true only in DEBUG builds, to match what we do for extraWarnings.
2. Set options.extraWarningsOption = true in non-DEBUG builds too.

Comment 1

[Jan de Mooij [:jandem]]

Or:

3. Hard-code options.extraWarningsOption = false in non-DEBUG. This might be the simplest fix...

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1568546 - Set extraWarningsOption to true in FillSelfHostingCompileOptions in non-debug builds too. r?anba!

This ensures behavior is not affected by the extraWarnings browser pref.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7849cfe656
Set extraWarningsOption to true in FillSelfHostingCompileOptions in non-debug builds too. r=anba

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8f7849cfe656