1568610 - Change PEHeaders::GetIATThunksForModule to return Maybe<Span<IMAGE_THUNK_DATA>>

Status: RESOLVED FIXED

(Core :: mozglue, task, P1)

Description

[Aaron Klotz [:aklotz]]

We should get rid of that IATThunks structure and just use Span instead.

This would be a good first bug for tkikuchi when he starts.

Comment 1

[Aaron Klotz [:aklotz]]

Assigning to Toshihito. This is a simple bug just to get you acquainted with some of our code, testing, and building.

Currently, PEHeaders::GetIATThunksForModule returns a Maybe<IATThunks>. We should delete the IATThunks structure and just use Maybe<Span<IMAGE_THUNK_DATA>> as the return type instead.

We already do this in PEHeaders::GetSectionTable but without using Maybe. It's the same idea, though.

When you submit your patch for review, please assign me as the reviewer.

Comment 2

[Toshihito Kikuchi [:toshi]]

Got it. Thank you for my first bug!

I've made a patch. Once my request for the try server is approved, I'll submit a try and start a review. Probably next week.

Comment 3

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1568610 - Delete the definition of IATThunks structure. r=aklotz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3689f85b1c39
Delete the definition of IATThunks structure. r=aklotz

Comment 5

[Andrei Ciure[:andrei_ciure]]

https://hg.mozilla.org/mozilla-central/rev/3689f85b1c39