Change PEHeaders::GetIATThunksForModule to return Maybe<Span<IMAGE_THUNK_DATA>>
Categories
(Core :: mozglue, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: aklotz, Assigned: toshi, Mentored)
Details
Attachments
(1 file)
We should get rid of that IATThunks structure and just use Span instead.
This would be a good first bug for tkikuchi when he starts.
|
Reporter | |
Comment 1•2 years ago
|
||
Assigning to Toshihito. This is a simple bug just to get you acquainted with some of our code, testing, and building.
Currently, PEHeaders::GetIATThunksForModule returns a Maybe<IATThunks>. We should delete the IATThunks structure and just use Maybe<Span<IMAGE_THUNK_DATA>> as the return type instead.
We already do this in PEHeaders::GetSectionTable but without using Maybe. It's the same idea, though.
When you submit your patch for review, please assign me as the reviewer.
|
Assignee | |
Comment 2•2 years ago
|
||
Got it. Thank you for my first bug!
I've made a patch. Once my request for the try server is approved, I'll submit a try and start a review. Probably next week.
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3689f85b1c39
Delete the definition of IATThunks structure. r=aklotz
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•