Closed Bug 1568610 Opened 4 months ago Closed 3 months ago

Change PEHeaders::GetIATThunksForModule to return Maybe<Span<IMAGE_THUNK_DATA>>

Categories

(Core :: mozglue, task, P1)

Unspecified
Windows
task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: aklotz, Assigned: toshi, Mentored)

Details

Attachments

(1 file)

We should get rid of that IATThunks structure and just use Span instead.

This would be a good first bug for tkikuchi when he starts.

Assigning to Toshihito. This is a simple bug just to get you acquainted with some of our code, testing, and building.

Currently, PEHeaders::GetIATThunksForModule returns a Maybe<IATThunks>. We should delete the IATThunks structure and just use Maybe<Span<IMAGE_THUNK_DATA>> as the return type instead.

We already do this in PEHeaders::GetSectionTable but without using Maybe. It's the same idea, though.

When you submit your patch for review, please assign me as the reviewer.

Assignee: nobody → tkikuchi
Mentor: aklotz
Status: NEW → ASSIGNED
Priority: P3 → P1

Got it. Thank you for my first bug!

I've made a patch. Once my request for the try server is approved, I'll submit a try and start a review. Probably next week.

Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3689f85b1c39
Delete the definition of IATThunks structure. r=aklotz

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.