"Show full diff" link is not always available
Categories
(Webtools :: Searchfox, defect)
Tracking
(Not tracked)
People
(Reporter: botond, Unassigned)
References
Details
STR
- Navigate to https://searchfox.org/mozilla-central/rev/d5b09287dc0986e2cb9adc353e629c29888eaac5/layout/base/nsLayoutUtils.cpp#709
- Hover over the left ruler on the highlighted line
Expected results
The hover contains links to show both "annotated diff" and "full diff".
Atual results
It only contains the link to show the "annotated diff".
Comment 1•5 years ago
|
||
The commit in question originally landed in CVS and predates mercurial. So we can't link to hg.m.o for it. The workaround for now is to click on the "annotated diff", then click on the rev in "showing e9feb985" just under the search bar, and then click on the "git" link which will take you to the github view of the commit. But we should really just add a direct link to github for "full diff" if we don't have a hg rev for it.
Reporter | ||
Comment 2•5 years ago
|
||
Does the absence of a "full diff" link imply a CVS-era changeset in general?
Comment 3•5 years ago
|
||
Not always. Sometimes we run into bug 1431906 where the hg changeset isn't in the blame repo. That shouldn't happen for any future changesets, but until we rebuild the blame repo it can still happen for some historical revisions.
Comment 4•4 years ago
|
||
The blame repo for m-c has been rebuilt, so now any missing "full diff" links should only be for CVS-era changesets. Leaving this bug open for adding a "full diff" link that goes to github if we don't have an hg rev.
Comment 5•4 years ago
|
||
https://github.com/mozsearch/mozsearch/blob/ae3034237d693c28d2fed68cf3d0f765abaf1795/tools/src/blame.rs#L61-L68 is the code that would need modification.
Description
•