"products" key in Events.yaml created duplicates
Categories
(Toolkit :: Telemetry, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: tjr, Assigned: janerik)
References
Details
Attachments
(2 files)
There are duplicate (and conflicting) products keys now. See https://searchfox.org/mozilla-central/rev/40e889be8ff926e32f7567957f4c316f14f6fbef/toolkit/components/telemetry/Events.yaml#1559,1575,1599,1615 for two examples, but there are others...
|
Assignee | |
Comment 1•5 years ago
|
||
Thanks for noticing and reporting.
That's indeed unintended and must have happened when we automatically added the "products" key to all probes.
I have a patch nearly done fixing this. Luckily Yaml simply picks the last assigned value and in all but one instance the new list was added before the already existing key, so nothing really broke.
|
|
Assignee | |
Comment 2•5 years ago
|
||
These were added by accident when we enforced having a products key.
Duplicates and wrong indentation was found using yamllint.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Because Yaml takes the last assigned value, not even the tests failed.
Depends on D39296
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d2ac413b309 Removed duplicate products key for events r=Dexter https://hg.mozilla.org/integration/autoland/rev/a4b8db7e09cb Removed duplicate products key for scalars r=Dexter
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1d2ac413b309
https://hg.mozilla.org/mozilla-central/rev/a4b8db7e09cb
Description
•