Thunderbird Update Verify non-fatal errors on macOS from version < 68
Categories
(Thunderbird :: Installer, defect, P2)
Tracking
(thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)
People
(Reporter: rjl, Assigned: rjl)
References
Details
Attachments
(1 file)
1.62 KB,
patch
|
darktrojan
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
Error on macOS Update Verify jobs (found in 69.0b1, affects 68.0+
[task 2019-07-23T23:20:53.784Z] Comparing source/Thunderbird.app with target/Thunderbird.app...
[task 2019-07-23T23:20:53.784Z] Files only in source/Thunderbird.app:
[task 2019-07-23T23:20:53.784Z] Contents/Library/Spotlight/thunderbird.mdimporter/Contents/_CodeSignature/._CodeResources
That file is unintentionally part of macOS DMG packages found in Thunderbird versions < 68. See bug 1482788.
The installer doesn't know about it if it's present, so it needs to be added to removed-files.in so it can be dealt with.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
This addresses Update-Verify errors on macOS during the release process on versions >=68.0.
Assignee | ||
Comment 2•5 years ago
|
||
The Update-Verify process is failing due to the new signature servers not producing these extra files. See Bug 1482788.
Depending on versions and locales involved, an updated installation could wind up with files not present in a pristine install (from DMG).
Files only in source/Thunderbird.app:
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/_CodeSignature/._CodeResources
Files only in source/Thunderbird.app:
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/._Info.plist
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/._schema.xml
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/English.lproj/._InfoPlist.strings
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/English.lproj/._schema.strings
Adding these files to removed-files ensures that they are not present after the updater runs.
Testing methodology:
I followed the procedure documented here.
I was able to replicate the results that the CI Update-Verify test produced.
python compare-directories.py --verbose start/Thunderbird.app destination/Thunderbird.app release-localtest
Comparing start/Thunderbird.app with destination/Thunderbird.app...
Files only in start/Thunderbird.app:
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/._Info.plist
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/._schema.xml
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/English.lproj/._InfoPlist.strings
Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/English.lproj/._schema.strings
The mar file I used was a specially crafted file made using this page as a guide. I modified "removed-files" as done in the above patch and regenerated the mar file.
Repeating the test, I was 99% successful:
python compare-directories.py --verbose start/Thunderbird.app destination/Thunderbird.app release-localtest 1m 53s
Comparing start/Thunderbird.app with destination/Thunderbird.app...
Difference found in Contents/Resources/removed-files
Got 0 transform(s) to consider for Contents/Resources/removed-files
Contents/Resources/removed-files still differs after transforms, residual diff:
---
+++
@@ -1,9 +1,3 @@
Contents/Resources/distribution/
Contents/Resources/distribution/extensions/
Contents/Resources/distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/*
-Contents/Library/Spotlight/thunderbird.mdimporter/Contents/_CodeSignature/._CodeResources
-Contents/Library/Spotlight/thunderbird.mdimporter/Contents/._Info.plist
-Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/._schema.xml
-Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/English.lproj/._InfoPlist.strings
-Contents/Library/Spotlight/thunderbird.mdimporter/Contents/Resources/English.lproj/._schema.strings
-
That difference makes perfect sense given that the DMG file I am comparing against does not have the updated removed-files.
I consider this a success!
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2f994e763d92
Remove erroneous signature files on update on Mac. r=darktrojan
Updated•5 years ago
|
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
Description
•