Closed Bug 1568708 Opened 5 years ago Closed 5 years ago

Modify setContextualTip, remove hide/show

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Iteration:
70.2 - Jul 22 - Aug 4
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: okonaraddi, Assigned: okonaraddi, Mentored)

References

Details

Attachments

(1 file)

Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!
47 bytes, text/x-phabricator-request
Details | Review

Changes to make to browser.urlbar.contextualTip.setContextualTip have been outlined in Bug 1559495 Comment 1 . The browser.urlbar.contextualTip.hide/show functions will be removed too.

Blocks: 1559495
Attachment #9080940 - Attachment description: Bug 1568708 - Modify setContextualTip, remove hide/show r=adw!,mak! → Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak!
Attachment #9080940 - Attachment description: Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak! → Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission, require use_contextual_tip manifest property r=adw!,mak!
Attachment #9080940 - Attachment description: Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission, require use_contextual_tip manifest property r=adw!,mak! → Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak!
Attachment #9080940 - Attachment description: Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak! → Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak!
Attachment #9080940 - Attachment description: Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak! → Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak!
Attachment #9080940 - Attachment description: Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!,mak! → Bug 1568708 - Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw!
Pushed by okonaraddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c108cd0d15da
Set contextual tip's texts, remove tip during onShutdown, require urlbar permission r=adw,mixedpuppy

https://hg.mozilla.org/mozilla-central/rev/c108cd0d15da

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: