Closed
Bug 1568729
Opened 6 years ago
Closed 6 years ago
Teach Codegen.py about the new static prefs file headers
Categories
(Core :: DOM: Bindings (WebIDL), task)
Core
DOM: Bindings (WebIDL)
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: bzbarsky)
Details
Attachments
(2 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
71.17 KB,
patch
|
Details | Diff | Splinter Review |
Bug 1563139 will split StaticPrefs.h into lots of pieces: StaticPrefs_dom.h, StaticPrefs_gfx.h, etc. This will greatly reduce the amount of recompilation required every time a static pref is added or changed.
However, I decided that updating Codegen.py to take advantage of the new split headers could be deferred to a follow-up. When bug 1563139 lands, Codegen.py will generate code that uses the new StaticPrefsAll.h file, which includes every StaticPrefs_*.h file. It should be changed to generate code that only uses the required StaticPrefs_*.h files. This will minimize the amount of recompilation done for DOM bindings files when a static pref is added or changed.
| Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bzbarsky
| Assignee | ||
Comment 1•6 years ago
|
||
| Assignee | ||
Comment 2•6 years ago
|
||
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8954a9b7f486
Only include the static pref headers we really need in binding code. r=peterv
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•