1568806 - Permafail TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/spec/address.wast.js bustages when Gecko 70 merges to Beta on 2019-08-26

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[Andrei Ciure[:aciure]]

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258274006&repo=try&lineNumber=9390

[task 2019-07-25T11:19:25.506Z] TEST-PASS | js/src/jit-test/tests/wasm/spec/binary.wast.js | Success (code 0, args "--wasm-compiler=ion") [0.2 s]
[task 2019-07-25T11:19:25.878Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal:
[task 2019-07-25T11:19:25.878Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 assert_return(() => call($1, "16u_good1", [0]), 25_185);
[task 2019-07-25T11:19:25.878Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 ..................................................^
[task 2019-07-25T11:19:25.878Z] Exit code: 3
[task 2019-07-25T11:19:25.878Z] FAIL - wasm/spec/address.wast.js
[task 2019-07-25T11:19:25.878Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/spec/address.wast.js | /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal: (code 3, args "") [0.8 s]
[task 2019-07-25T11:19:25.878Z] INFO exit-status : 3
[task 2019-07-25T11:19:25.878Z] INFO timed-out : False
[task 2019-07-25T11:19:25.878Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal:
[task 2019-07-25T11:19:25.878Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 assert_return(() => call($1, "16u_good1", [0]), 25_185);
[task 2019-07-25T11:19:25.878Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 ..................................................^
[task 2019-07-25T11:19:25.926Z] TEST-PASS | js/src/jit-test/tests/wasm/regress/too-large-frame.js | Success (code 0, args "") [1.2 s]
[task 2019-07-25T11:19:25.960Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal:
[task 2019-07-25T11:19:25.960Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 assert_return(() => call($1, "16u_good1", [0]), 25_185);
[task 2019-07-25T11:19:25.960Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 ..................................................^
[task 2019-07-25T11:19:25.960Z] Exit code: 3
[task 2019-07-25T11:19:25.960Z] FAIL - wasm/spec/address.wast.js
[task 2019-07-25T11:19:25.960Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/spec/address.wast.js | /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal: (code 3, args "--test-wasm-await-tier2") [0.9 s]
[task 2019-07-25T11:19:25.960Z] INFO exit-status : 3
[task 2019-07-25T11:19:25.961Z] INFO timed-out : False
[task 2019-07-25T11:19:25.961Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal:
[task 2019-07-25T11:19:25.961Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 assert_return(() => call($1, "16u_good1", [0]), 25_185);
[task 2019-07-25T11:19:25.961Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 ..................................................^
[task 2019-07-25T11:19:25.978Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal:
[task 2019-07-25T11:19:25.978Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 assert_return(() => call($1, "16u_good1", [0]), 25_185);
[task 2019-07-25T11:19:25.978Z] /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 ..................................................^
[task 2019-07-25T11:19:25.978Z] Exit code: 3
[task 2019-07-25T11:19:25.979Z] FAIL - wasm/spec/address.wast.js
[task 2019-07-25T11:19:25.980Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/spec/address.wast.js | /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal: (code 3, args "--wasm-compiler=baseline") [0.9 s]
[task 2019-07-25T11:19:25.981Z] INFO exit-status : 3
[task 2019-07-25T11:19:25.981Z] INFO timed-out : False
[task 2019-07-25T11:19:25.986Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 SyntaxError: identifier starts immediately after numeric literal:
[task 2019-07-25T11:19:25.986Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 assert_return(() => call($1, "16u_good1", [0]), 25_185);
[task 2019-07-25T11:19:25.986Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/spec/address.wast.js:36:50 ..................................................^

Comment 1

[Nicolas B. Pierron [:nbp]]

Julian, do you mind looking at this issue, or find the right person who can fix it before the merge date?

Comment 2

[Ryan Hunt [:rhunt]]

I'm looking into it as it's the fallout from my work in bug 1566516. I'm hoping to get it fixed in bug 1435818.

Comment 3

[Ryan Hunt [:rhunt]]

Actually, I just noticed that the soft freeze is tomorrow so I'm unsure if bug 1435818 is the best fix. I'll try to prepare a fix to the test generator.

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 1568806 - Wasm: Patch spec-tests to stop grouping digits. r?jseward

This commit imports the spec-tests with an additional patch to not group digits [1].

This is needed to prevent some test failures when central merges to beta, as the
spec test generator inserts underscores inside numeric literals, and that feature
is only enabled on nightly currently.

[1] https://github.com/eqrion/spec/commit/55316716b408a7e4001c79442b188c4a899b0493

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 6

[Ryan Hunt [:rhunt]]

The problem is that the imported tests from bug 1566516 contained numeric literals with '_' separators, but that feature is limited to nightly. I've just landed a patch in bug 1435818 to let the numeric separators feature ride the trains to release, which should fix this bug.

The attached patch was a workaround if bug 1435818 couldn't be landed in time, but shouldn't be needed.

Comment 7

[Cristian Brindusan [:cbrindusan]]

Applying this patch fixes this failure:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=b869c6ffc55837ac2cdf17a92ebde5d00f9527fc&selectedJob=258467513

Comment 8

[Cosmin Sabou [:CosminS]]

Verified fix in today's beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=2d55d46e818c791096b9c8c2e7114568e072e667&searchStr=spidermonkey%2Cbuilds%2C

Comment 9

[Intermittent Failures Robot]

1 failures in 4608 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1568806&startday=2019-07-22&endday=2019-07-28&tree=all