1568823 - Simplify/remove devtools' Parser.jsm

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

See Bug 1563474. Most of https://searchfox.org/mozilla-central/rev/40e889be8ff926e32f7567957f4c316f14f6fbef/devtools/shared/Parser.jsm is unused and can be removed. There is also no need to keep this as a JSM.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1568823 - Remove all unused methods from Parser.jsm

Depends on D39321

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1568823 - Stop exporting reflectionAPI from Parser.jsm

Depends on D39332

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1568823 - Move Parser.jsm to a regular module in devtools/shared/webconsole

Depends on D39333

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1568823 - Simplify parser.js and rename to parser-helper

Depends on D39335
Looking in details at get(), the implementation can also be simplified

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Oh, if we could not have this as a jsm, we could use it in Worker context, and we could simplify js-property-provider !

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #5)

Oh, if we could not have this as a jsm, we could use it in Worker context, and we could simplify js-property-provider !

Sorry for giving any false hope, but even if the file can be a regular module, it still needs to use reflect.jsm, so it will still be a no go in worker environments I guess :/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66876e1aedd8
Remove all unused methods from Parser.jsm r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/b6e25b59fb8c
Stop exporting reflectionAPI from Parser.jsm r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d83446689677
Move Parser.jsm to a regular module in devtools/shared/webconsole r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/549f27fe407d
Simplify parser.js and rename to parser-helper r=nchevobbe

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/66876e1aedd8
https://hg.mozilla.org/mozilla-central/rev/b6e25b59fb8c
https://hg.mozilla.org/mozilla-central/rev/d83446689677
https://hg.mozilla.org/mozilla-central/rev/549f27fe407d