Closed Bug 1568860 Opened 4 months ago Closed 27 days ago

Make the Font Editor able to display and edit font information about any selected node, even when those nodes are in oop iframes

Categories

(DevTools :: Inspector: Fonts, enhancement, P1)

enhancement

Tracking

(Fission Milestone:M4, firefox71 fixed)

RESOLVED FIXED
Firefox 71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: pbro, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(3 files)

With fission, and once bug 1560200 is fixed, we'll be able to select nodes in the inspector that may live in out of process iframes.

When this happens, the Font Editor must continue being able to display and edit the corresponding font information.

Additionally, it must still be able to list all the fonts found on the page, even those found in oop frames.

Priority: P3 → P2
Whiteboard: dt-fission
Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: dt-fission-reserve → dt-fission

While looking through the codebase for remaining callsites to be updated for fission, I stumbled upon this line that might need to be changed here:

https://searchfox.org/mozilla-central/rev/b6f088f2f68d2a8ae0b49d6c8fbd7cbd3a65fa5b/devtools/client/inspector/fonts/fonts.js#487
This is used to get the documentElement node to convert to rem units. We should change this so it returns the documentElement node of the parent frame of the current node.

Keywords: leave-open
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b444f7b10ef
Part 1: Use PageStyle from the currently selected element in the fonts view. r=ochameau
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b400a9d8abee
Part 2: Make getAllFonts fission compatible. r=ochameau
Keywords: leave-open
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5887f4095a87
Part 3: Use the contextual WalkerFront in the fonts view. r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.