Closed Bug 1568873 Opened 5 years ago Closed 5 months ago

License linter emits old error when fixing

Categories

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Tracking

(firefox123 fixed)

RESOLVED FIXED
Tracking Status
firefox123 --- fixed

People

(Reporter: ato, Assigned: standard8)

Details

Attachments

(1 file)

Using ./mach lint --fix to add missing licensing headers
causes the errors that it has already fixed to be re-emitted.

Steps to reproduce

  1. Remove the licensing header from remote/pref/remote.js.
  2. Run ./mach lint remote/ to ensure it complains that the file is missing a license.
  3. Run ./mach lint --fix remote/.

Expected

The license header to be added and no error emitted.

Actual

% ./mach lint --fix remote
/home/ato/src/gecko/remote/pref/remote.js
  0   error  No matching license strings found in tools/lint/license/valid-licenses.txt  (license)

✖ 1 problem (1 error, 0 warnings)
Priority: -- → P3
Product: Firefox Build System → Developer Infrastructure
Severity: normal normal → S3 S3
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e007454356a4
Prevent the license linter from emitting errors for files it has fixed. r=linter-reviewers,sylvestre
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: