Update Fluent.jsm to @fluent/bundle 0.14.0
Categories
(Core :: Internationalization, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
This bug is about updating Fluent in Gecko to the new FluentBundle API.
Update plan:
-
Update Fluent.jsm to @fluent/bundle 0.14
-
bundle.formatPattern()
- Use formatPattern in Localization.jsm
- Use formatPattern in intl.l10n/test/test_messagecontext.js
-
new FluentResource()
- Don’t use FluentResource.fromString() in L10nRegistry
- Update devtools/client to a new version of @fluent/react, capable of using the new formatPattern API
- Bug 1555902 has a WIP upgrading to fluent-react 0.8.4
- Don’t use FluentResource.fromString() in browser_misused_characters_in_strings.js
- https://searchfox.org/mozilla-central/search?q=FluentResource.fromString&case=false®exp=false&path=browser_misused_characters_in_strings.js
- Don’t switch to fluent-syntax for now; too much work.
-
bundle.addMessages()
- Don’t use addMessages in test files
https://searchfox.org/mozilla-central/search?q=addMessages&case=false®exp=false&path=test - Don’t use addMessages in Activity Stream
https://searchfox.org/mozilla-central/search?q=addMessages&case=false®exp=false&path=rich-text-strings.js- Update in GitHub https://github.com/mozilla/activity-stream/blob/master/content-src/asrouter/rich-text-strings.js#L41
- Can happen out-of-band. AS bundles the npm version of Fluent.
- Don’t use addMessages in test files
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
The attached patch is a WIP, I'd like to land it on Monday. It's based on the following release branch in fluent.js: https://github.com/projectfluent/fluent.js/pull/408. Since yesterday, I discovered one issue with wrapping arguments in FluentNumber and FluentDateTime, which I fixed on the release branch in https://github.com/projectfluent/fluent.js/pull/410.
The latest two tries are:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed1b402920e17af01aa626cf4efe775171b71583
https://treeherder.mozilla.org/#/jobs?repo=try&revision=90aa2f295cf9290fe5cb47d78337c2d9711a8300
|
||
Updated•5 years ago
|
| Comment hidden (obsolete) |
|
||
Updated•5 years ago
|
Pushed by flodolo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b513d98a80e Update Fluent to @fluent/bundle 0.14.0 r=zbraniecki,jdescottes
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Description
•