Closed Bug 1568940 Opened 5 years ago Closed 5 years ago

Prompted to save password when clicking a link on any page with a password field

Categories

(Toolkit :: Password Manager, defect)

68 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1388674

People

(Reporter: billynoah, Unassigned)

References

()

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

  1. Visit any page with a form containing a password field.
  2. Click a normal link to navigate away from the page, and which does not submit the form.

Actual results:

Dialog asking if I "would like Firefox to save this password for example.com" appears.

Expected results:

Previously only a form submission / POST request would trigger this dialog to appear. Since no form has been submitted here, I am under the impression that this is a bug. If this is new behaviour and is by design, it is terribly disruptive since I am now constantly bombarded with the "save this password" dialog box. Many sites contain inline forms or password fields in navigation areas and simply clicking a link to navigate away from a page should not be prompting to save a password.

Component: Untriaged → Password Manager
Product: Firefox → Toolkit

Hello, thanks for the report, this is not intentional behaviour unless something/someone other than Firefox filled the password field.

  • Do you have another password manager extension or some other extensions that fills password fields?
  • Can you reproduce the issue in Safe Mode?
    • Also, could you give a URL that you can reproduce the issue on in Safe Mode?
Flags: needinfo?(billynoah)

Thanks for bringing that to my attention Matthew. The site in question is actually populating the password field with a random string. I won't go into detail about why, but in the context of the application it makes sense. I can see that when I manually empty the password field, things behave normally. So apparently this is related to navigating away from a page when anything at all has been populated in the password field, which is a bit less problematic, but still not what I'd expect.

Since I don't recall this ever happening before, again I'm guessing that it might be new behaviour? IMO, the "save this password" dialog box should not appear unless the form is submitted. Can you confirm whether or not the thing I'm observing here is a bug or not? And if not, when was this introduced?

Flags: needinfo?(billynoah)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Hello, thanks for the report, this is not intentional behaviour unless something/someone other than Firefox filled the password field.

  • Do you have another password manager extension or some other extensions that fills password fields?
  • Can you reproduce the issue in Safe Mode?
    • Also, could you give a URL that you can reproduce the issue on in Safe Mode?

I believe we've narrowed this down with my previous response but to more directly answer your questions:

  • Do you have another password manager extension or some other extensions that fills password fields?
    No.

Also, please note, the demo page I created does not even contain a form. A password field present on the page is enough the trigger the dialog, regardless of whether or not a form is present, submitted or the user has even typed anything.

Thank you, it was a change in bug 1287202 (Fx68) and bug 1388674 is our solution to it. Thank you for the detailed responses.

Blocks: 1287202
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE

excellent - thanks for tracking that down

You need to log in before you can comment on or make changes to this bug.