1568946 - Add better error message when addon install fails

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

Currently when the addon install fails in policy, we just say "download failed"

We should provide more info.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1568946 - Add better errors when addon install policy fails.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2637c6d8e3c3
Add better errors when addon install policy fails. r=aswan

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2637c6d8e3c3

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9080712 [details]
Bug 1568946 - Add better errors when addon install policy fails.

Beta/Release Uplift Approval Request

• User impact if declined: Hard for enterprises to detect download error.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds an extra string to the error message logged on the console.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9080712 [details]
Bug 1568946 - Add better errors when addon install policy fails.

Low risk and had automated tests, approved for 69 beta 11, thanks.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/e429e0d918be

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 9080712 [details]
Bug 1568946 - Add better errors when addon install policy fails.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Simple change that makes debugging addon installation failures easier
• User impact if declined: Harder for admins to determine error
• Fix Landed on Version: 70/69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds additional info to an error message.
• String or UUID changes made by this patch:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9080712 [details]
Bug 1568946 - Add better errors when addon install policy fails.

error message improvement, approved for 68.1esr

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/8cf3ff9d2b1a