Closed Bug 1569019 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 18090 - Reland "Re-write test pointerevent_pointermove_in_pointerlock.html"

Categories

(Core :: DOM: Events, task, P4)

Product:
Core
Component:
DOM: Events
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18090 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18090
Details from upstream follow.

Ella Ge <eirage@chromium.org> wrote:

Reland "Re-write test pointerevent_pointermove_in_pointerlock.html"

This reverts commit 02efc0f4be0797b2c151e4aa598b125a6eccf191.

Reason for revert: [Cherry-picked & WIP] reland with fixing the test.

Original change's description:

Revert "Re-write test pointerevent_pointermove_in_pointerlock.html"

This reverts commit 9b7bafff73e59dc5d0cfcd0f499aa20be66bca54.

Reason for revert: Causing leak failures on WebKit Linux Leak bot

https://luci-milo.appspot.com/p/chromium/builders/ci/WebKit%20Linux%20Leak/2348

Original change's description:

Re-write test pointerevent_pointermove_in_pointerlock.html

The test was failing in wpt because it passing non-integer value to
test driver. This CL changes it to use "origin" instead.
This CL rewrites the test to makes it cleaner, instead of adding event
listener inside event listener.
This CL also changes the test to send the "move" events after receiving
pointerlockchange.

Bug: 986277
Change-Id: I0f51523c3c90791339877b2e51afa8e9a4cc9d4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717195
Reviewed-by: Lan Wei \<lanwei@chromium.org>
Commit-Queue: Ella Ge \<eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680563}

TBR=lanwei@chromium.org,eirage@chromium.org

Change-Id: Ia53d1066363ceaf804f61ada369a4126c859f875
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716038
Reviewed-by: Noel Gordon \<noel@chromium.org>
Commit-Queue: Noel Gordon \<noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680743}

TBR=noel@chromium.org,lanwei@chromium.org,eirage@chromium.org

Bug: 986277
Change-Id: I9b104597d2965261104e5842855ab235bdec8081

Reviewed-on: https://chromium-review.googlesource.com/1719227
WPT-Export-Revision: 2d4a0bc4ab6474bd7eb1cdf994081e8e5c694bef

Component: web-platform-tests → DOM: Events
Product: Testing → Core
Ran 1 tests and 1[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt] subtests TIMEOUT: 1[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt] ERROR : 1[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] NOTRUN : 1[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt] New tests that have failures or other problems: /pointerevents/pointerlock/pointerevent_pointermove_in_pointerlock.html pointermove event received: NOTRUN[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07777679a5ef [wpt PR 18090] - Reland "Re-write test pointerevent_pointermove_in_pointerlock.html", a=testonly

https://hg.mozilla.org/mozilla-central/rev/07777679a5ef

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.