1569021 - Compare page has bogus URL for Graph links, with invalid highlightedRevisions

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Steve Fink [:sfink] [:s:]]

See eg https://treeherder.mozilla.org/perf.html#/graphs?series=try,fcefb979eac44d057f9c05434580ce7845f4c2d6,1,1&highlightedRevisions=476cf1aea384,2f1bef963074&timerange=1209600

It claims to be highlighting 476cf1aea384. Right in the middle of July 23, I can find that revision. It does not appear any more or less highlighted than every other displayed revision.

Bug 1532533 seems to be talking about the same thing, though it mentions a gray line for highlighting? In any case, I don't see any lines either.

Comment 1

[Sarah Clements [:sclements]]

The revisions should not be comma separated; instead of highlightedRevisions=476cf1aea384,2f1bef963074 it needs to be highlightedRevisions=476cf1aea384&highlightedRevisions=2f1bef963074

See: https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=try,1638369,1,1&highlightedRevisions=476cf1aea384&highlightedRevisions=2f1bef963074

Comment 2

[Steve Fink [:sfink] [:s:]]

(In reply to Sarah Clements [:sclements] from comment #1)

The revisions should not be comma separated; instead of highlightedRevisions=476cf1aea384,2f1bef963074 it needs to be highlightedRevisions=476cf1aea384&highlightedRevisions=2f1bef963074

See: https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=try,1638369,1,1&highlightedRevisions=476cf1aea384&highlightedRevisions=2f1bef963074

Then that's the bug. I'll reuse this bug.

Go to https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=476cf1aea384f6600a92df283426d112ca6dc1d4&newProject=try&newRevision=2f1bef963074c1698702eb412fa7e463e8ed6dba (which came from filling out the page where you choose revisions to compare).

That gives the compare page. Click on any of the "Graph" links, eg the linux64 row under "a11yr opt e10s stylo". It gives the URL https://treeherder.mozilla.org/perf.html#/graphs?series=try%2Cfcefb979eac44d057f9c05434580ce7845f4c2d6%2C1%2C1&highlightedRevisions=476cf1aea384%2C2f1bef963074&timerange=2592000 which as per comment 1 is invalid. (It also doesn't seem to validate the highlightedRevisions value and happily says that revision "476cf1aea384,2f1bef963074" is being highlighted.)

Comment 3

[Sarah Clements [:sclements]]

Ah, I see, I'll get that fixed in the next pr. Thanks!

Comment 4

[Sarah Clements [:sclements]]

Fixed in this commit: https://github.com/mozilla/treeherder/commit/47b53c157ad5a1c496aa765c4a9c6cc7d3fdb9ae