Closed Bug 1569036 Opened 1 year ago Closed 1 year ago

Remove all the `aSkipAssignment` parameters

Categories

(Core :: Preferences: Backend, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

These parameters can be avoided.

AddVarCache() has a bool aSkipAssignment parameter. This patch removes that
parameter by splitting the function in two: AddVarCache() and
AddVarCacheNoAssignment(). (The former calls the latter.)

There are also tons of Add*VarCache() functions with aSkipAssignment
parameters that default to false. These defaults are never overridden, so
this patch removes the unnecessary arguments.

Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea3fe961404a
Remove all the `aSkipAssignment` parameters. r=KrisWright
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.