Closed
Bug 1569036
Opened 6 years ago
Closed 6 years ago
Remove all the `aSkipAssignment` parameters
Categories
(Core :: Preferences: Backend, task, P3)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
Details |
These parameters can be avoided.
|
Assignee | |
Comment 1•6 years ago
|
||
AddVarCache() has a bool aSkipAssignment parameter. This patch removes that
parameter by splitting the function in two: AddVarCache() and
AddVarCacheNoAssignment(). (The former calls the latter.)
There are also tons of Add*VarCache() functions with aSkipAssignment
parameters that default to false. These defaults are never overridden, so
this patch removes the unnecessary arguments.
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea3fe961404a
Remove all the `aSkipAssignment` parameters. r=KrisWright
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•