1569093 - Don't offer generated passwords via the context menu on sites where the user disabled password saving

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Matthew N. [:MattN]]

Same as bug 1554005 but for the context menu.

Comment 1

[Matthew N. [:MattN]]

We should fix https://searchfox.org/mozilla-central/rev/0bcdfa99339c0512e3730903835fb6f8ed45e3c4/toolkit/components/passwordmgr/LoginManagerParent.jsm#751-757 to throw in this case instead.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1569093 - Use getLoginOrigin instead of documentURI in LoginManagerContextMenu. r=jaws

This properly handles the userPass portion of the URI.

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1569093 - Don't offer pwgen via the context menu on sites where the user disabled pw saving. r=jaws

Depends on D39937

Comment 4

[Matthew N. [:MattN]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&author=mozilla%40noorenberghe.ca&fromchange=a0b36963d2bf309a90c0c6707654267b75b151f5

Feel free to land if I get r+ without changes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2ea63844d2e
Use getLoginOrigin instead of documentURI in LoginManagerContextMenu. r=jaws
https://hg.mozilla.org/integration/autoland/rev/06f72b9d9d14
Don't offer pwgen via the context menu on sites where the user disabled pw saving. r=sfoster

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f2ea63844d2e
https://hg.mozilla.org/mozilla-central/rev/06f72b9d9d14

Comment 7

[Daniel Bodea [:danibodea]]

Attachment: context menu shows a grayed out option.png

When the user blocks a site from saving logins and attempts to generate a password, he will notice that the "Use securely generated password" option is not displayed.
Verified on Nightly v70.0a1 on Windows 10, Mac OS 10.13.6 and Ubuntu 18.04.