1569128 - [wpt-sync] Sync PR 18108 - Revert "[LargestContentfulPaint] Set startTime"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 18108 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18108
Details from upstream follow.

Friedrich [CET] <[e-mail]> wrote:

Revert "[LargestContentfulPaint] Set startTime"

This reverts commit 58051e426031caabd8ae28b96a9be1f92f3cd913.

Reason for revert: Most suspicious CL for failing paint-related test
failures as mentioned in the linked bug.

Bug: 987915

Original change's description:

[LargestContentfulPaint] Set startTime

Currently startTime is 0, which is a problem because getEntries()
methods all sort by startTime. To help with this problem, we set the
startTime to renderTime, if available, or to loadTime, if renderTime is
nt available.

Bug: 965505
Change-Id: Ie70b69269f7ce4be0fdc94f33a44a84e062d3ba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719379
Reviewed-by: Yoav Weiss \<[e-mail]>
Commit-Queue: Nicolás Peña Moreno \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#681147}

TBR=[e-mail],[e-mail]

Change-Id: Ie810b8a3ac88369ab73a66670865f462f590e1ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719351
Reviewed-by: Friedrich [CET] \<[e-mail]>
Commit-Queue: Friedrich [CET] \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#681224}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 18108 applied with additional changes from upstream: 09143c197281e64651bad6e92a9397fd7eff084a, 10f3317909fa85cbed876da201871dcb735ad6f0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=feb051eb44ef7e211b78b244e179a1a5927d601a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=279ea5c72c95313bd2cbdf8f0323e1b7e50823a9

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 8 tests and 8 subtests
OK     : 8
FAIL   : 8

New tests that have failures or other problems:
/largest-contentful-paint/loadTime-after-appendChild.html
    Image loadTime occurs after appendChild is called.: FAIL
/largest-contentful-paint/repeated-image.html
    Repeated image produces different timestamps.: FAIL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f31645b3d8a
[wpt PR 18108] - Revert "[LargestContentfulPaint] Set startTime", a=testonly

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2f31645b3d8a