1569213 - minor fixup to nsBaseHashtable's OrInsert's docs

Status: RESOLVED INVALID

(Core :: XPCOM, task)

Description

[Aria Beingessner [:Gankra]]

I ended up pushing an older patch for this in Bug 1547351.

Should have pushed up this patch: https://hg.mozilla.org/try/rev/66d96ea7466123dbbc307b9881257493075a6e33

Note the change from auto to auto& in the docs and nsTraceRefcnt.cpp. The latter I'm surprised isn't causing catastrophic issues for someone. Perhaps it's dead code?

Comment 1

[Dave Townsend [:mossop]]

(In reply to Alexis Beingessner [:Gankro] from comment #0)

Note the change from auto to auto& in the docs and nsTraceRefcnt.cpp. The latter I'm surprised isn't causing catastrophic issues for someone. Perhaps it's dead code?

I fixed this case in bug 1569682. Yes it was causing catastrophic issues, but only when a certain type of leak logging was enabled.

Comment 2

[Aria Beingessner [:Gankra]]

oof, sorry about letting this sit and waste your time! Unfortunate consequence of noticing this friday afternoon

editing to make this just about fixing the docs

Comment 3

[Simon Giesecke [:sg] [he/him]]

EntryPtr::OrInsert does no longer exist. There is a redesigned EntryHandle with a OrInsert method now, though. It has also revamped documentation. I am not sure what fixup you were suggesting originally. Maybe the issue has been addressed through the redesign?