Closed
Bug 1569252
Opened 5 years ago
Closed 5 years ago
Move HasColumnSpanSiblings boolean property into nsIFrame
Categories
(Core :: Layout: Columns, task, P3)
Core
Layout: Columns
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(2 files)
Per bug 1351924 comment 31, we now have spare bits in nsIFrame to use. We can move HasColumnSpanSiblings boolean property into nsIFrame to save some FirstInFlow() traversal to be added in https://phabricator.services.mozilla.com/D38124
This is also tied to https://phabricator.services.mozilla.com/D39060.
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
We want mHasColumnSpanSiblings to propagate to all the
continuations (both fixed ones or fluid ones) in nsFrame::Init() so that
we don't need to traverse all the way to FirstInFlow() for the bit in
nsBlockFrame::ComputeFinalBSize().
Depends on D40760
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d02896d5e083 Part 1 - Convert nsIFrame::HasColumnSpanSiblings() property into an nsIFrame bit. r=dbaron https://hg.mozilla.org/integration/autoland/rev/54d0d836b097 Part 2 - Let mHasColumnSpanSiblings propagate to all the continuations. r=dbaron
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d02896d5e083
https://hg.mozilla.org/mozilla-central/rev/54d0d836b097
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•