Closed Bug 1569323 Opened 4 months ago Closed 3 months ago

251,100 instances of "NS_ENSURE_SUCCESS(mStatus, *this) failed with result 0x80004005" emitted from obj-firefox/dist/include/nsIURIMutator.h during linux64 debug testing

Categories

(Core :: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

251051 WARNING: NS_ENSURE_SUCCESS(mStatus, *this) failed with result 0x80004005: file obj-firefox/dist/include/nsIURIMutator.h, line 489

This warning [1] shows up in the following test suites:

  6515 - test-linux64/debug-jsreftest-sw-e10s-1 J1
  6515 - test-linux64/debug-jsreftest-e10s-4 J4
  6515 - test-linux64/debug-jsreftest-sw-e10s-3 J3
  6515 - test-linux64/debug-jsreftest-e10s-3 J3
  6515 - test-linux64/debug-jsreftest-e10s-2 J2
  6515 - test-linux64/debug-jsreftest-e10s-1 J1
  6515 - test-linux64/debug-jsreftest-sw-e10s-4 J4
  6515 - test-linux64/debug-jsreftest-e10s-5 J5
  6515 - test-linux64/debug-jsreftest-sw-e10s-2 J2
  6515 - test-linux64/debug-jsreftest-sw-e10s-5 J5
  3807 - test-linux64/debug-crashtest-e10s C
  3807 - test-linux64/debug-crashtest-sw-e10s C
  2571 - test-linux64/debug-reftest-e10s-5 R5
  2571 - test-linux64/debug-reftest-sw-e10s-5 R5
  2571 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
  2571 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
  2481 - test-linux64/debug-reftest-e10s-6 R6
  2481 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
  2481 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
  2481 - test-linux64/debug-reftest-sw-e10s-6 R6
  2479 - test-linux64/debug-reftest-e10s-7 R7
  2479 - test-linux64/debug-reftest-sw-e10s-7 R7
  2479 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
  2479 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
  2472 - test-linux64/debug-reftest-e10s-2 R2
  2472 - test-linux64/debug-reftest-sw-e10s-2 R2
  2471 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
  2471 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
  2459 - test-linux64/debug-reftest-sw-e10s-3 R3
  2459 - test-linux64/debug-reftest-e10s-3 R3
  2455 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
  2455 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
  2445 - test-linux64/debug-reftest-sw-e10s-1 R1
  2445 - test-linux64/debug-reftest-e10s-1 R1
  2445 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
  2444 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
  2355 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
  2355 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
  2350 - test-linux64/debug-reftest-sw-e10s-4 R4
  2350 - test-linux64/debug-reftest-e10s-4 R4
  2234 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
  2219 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
  2120 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
  2118 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
  2114 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
  2098 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
  2035 - test-linux64/debug-reftest-e10s-8 R8
  2035 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
  2035 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
  2035 - test-linux64/debug-reftest-sw-e10s-8 R8
  1951 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
  1950 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
  1944 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
  1937 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
  1921 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
  1900 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
  1873 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
  1867 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
  1760 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
  1746 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
  1735 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
  1731 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
  1677 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
  1676 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
  1638 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
  1633 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
  1568 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
  1554 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
  1540 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
  1529 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
  1418 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
  1411 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
  1405 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
  1400 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
  1372 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
  1371 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
  1324 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
  1324 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
  1308 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
  1284 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
  1217 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
  1215 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
  1129 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
  1115 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
  1094 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-2 Wd2
  1094 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
  1065 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
  1059 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
   845 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
   837 - test-linux64/debug-marionette-e10s Mn
   827 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-3 Wr3
   819 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
   811 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
   806 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-2 Wr2
   806 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
   773 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
   773 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-1 Wr1
   715 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
   715 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-4 Wr4
   613 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
   605 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
   583 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
   572 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
   567 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
   553 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
   542 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
   538 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
   525 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
   464 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
   447 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
   434 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   424 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
   409 - test-linux64/debug-mochitest-sw-e10s-15 15
   404 - test-linux64/debug-mochitest-e10s-15 15
   400 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
   400 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-8 dt8
   397 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
   393 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
   381 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
   375 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
   355 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
   346 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
   345 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
   343 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
   332 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
   330 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
   303 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
   300 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
   298 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
   286 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
   277 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
   273 - test-linux64/debug-mochitest-e10s-8 8
   272 - test-linux64/debug-mochitest-sw-e10s-4 4
   271 - test-linux64/debug-mochitest-e10s-4 4
   264 - test-linux64/debug-mochitest-sw-e10s-8 8
   219 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
   203 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
   197 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
   195 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-6 dt6
   190 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
   187 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
   185 - test-linux64/debug-mochitest-e10s-2 2
   185 - test-linux64/debug-mochitest-sw-e10s-2 2
   179 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
   177 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
   169 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
   160 - test-linux64/debug-mochitest-e10s-12 12
   160 - test-linux64/debug-mochitest-sw-e10s-12 12
   151 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
   150 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-10 dt10
   145 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
   136 - test-linux64/debug-mochitest-sw-e10s-1 1
   136 - test-linux64/debug-mochitest-e10s-1 1
   134 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
   129 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
   123 - test-linux64/debug-mochitest-sw-e10s-14 14
   123 - test-linux64/debug-mochitest-e10s-14 14
   122 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
   118 - test-linux64/debug-mochitest-e10s-7 7
   116 - test-linux64/debug-mochitest-sw-e10s-7 7
   115 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
   114 - test-linux64/debug-mochitest-e10s-9 9
   114 - test-linux64/debug-mochitest-sw-e10s-9 9
   108 - test-linux64/debug-mochitest-e10s-16 16
   108 - test-linux64/debug-mochitest-sw-e10s-16 16
   107 - test-linux64/debug-mochitest-e10s-3 3
   107 - test-linux64/debug-mochitest-sw-e10s-3 3
   104 - test-linux64/debug-mochitest-sw-e10s-5 5
   104 - test-linux64/debug-telemetry-tests-client-e10s c
   104 - test-linux64/debug-mochitest-e10s-5 5
   103 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-2 dt2
   102 - test-linux64/debug-mochitest-e10s-6 6
   102 - test-linux64/debug-mochitest-sw-e10s-6 6
    93 - test-linux64/debug-mochitest-sw-e10s-13 13
    93 - test-linux64/debug-mochitest-e10s-13 13
    92 - test-linux64/debug-mochitest-e10s-11 11
    92 - test-linux64/debug-mochitest-sw-e10s-11 11
    84 - test-linux64/debug-mochitest-sw-e10s-10 10
    84 - test-linux64/debug-mochitest-e10s-10 10
    79 - test-linux64/debug-mochitest-media-spi-e10s-1 mda1
    79 - test-linux64/debug-mochitest-media-sw-e10s-1 mda1
    79 - test-linux64/debug-mochitest-media-e10s-1 mda1
    74 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
    65 - test-linux64/debug-mochitest-media-sw-e10s-3 mda3
    65 - test-linux64/debug-mochitest-media-e10s-3 mda3
    65 - test-linux64/debug-mochitest-media-spi-e10s-3 mda3
    62 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
    62 - test-linux64/debug-mochitest-media-sw-e10s-2 mda2
    60 - test-linux64/debug-mochitest-media-spi-e10s-2 mda2
    60 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
    60 - test-linux64/debug-mochitest-media-e10s-2 mda2
    55 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
    46 - test-linux64/debug-mochitest-remote-sw-e10s remote
    45 - test-linux64/debug-mochitest-remote-e10s remote
    40 - test-linux64/debug-mochitest-webgl1-core-sw-e10s gl1c
    40 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
    40 - test-linux64/debug-mochitest-gpu-sw-e10s gpu
    40 - test-linux64/debug-mochitest-gpu-e10s gpu
    21 - test-linux64/debug-mochitest-chrome-sw-1proc-3 c3
    20 - test-linux64/debug-mochitest-chrome-1proc-3 c3
    17 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
     8 - test-linux64/debug-mochitest-chrome-sw-1proc-1 c1
     8 - test-linux64/debug-mochitest-webgl1-ext-sw-e10s gl1e
     8 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
     8 - test-linux64/debug-mochitest-chrome-1proc-1 c1
     7 - test-linux64/debug-marionette-media-e10s MnM
     1 - test-linux64/debug-mochitest-chrome-1proc-2 c2
     1 - test-linux64/debug-mochitest-chrome-sw-1proc-2 c2

It shows up in 74403 tests. A few of the most prevalent:

  5935 - [e10s] Shutdown
   430 - [e10s] dom/tests/browser/browser_noopener.js
   311 - [e10s] toolkit/components/antitracking/test/browser/browser_referrerDefaultPolicy.js
   169 - [e10s] browser/components/sessionstore/test/browser_newtab_userTypedValue.js
   124 - [e10s] dom/tests/browser/browser_focus_steal_from_chrome.js
   120 - [e10s] /webdriver/tests/forward/user_prompts.py
   120 - [e10s] /webdriver/tests/back/user_prompts.py
   120 - [e10s] /webdriver/tests/close_window/user_prompts.py
   106 - [e10s] browser/components/sessionstore/test/browser_354894_perwindowpb.js
   100 - [e10s] browser/base/content/test/tabs/browser_overflowScroll.js

[1] https://hg.mozilla.org/mozilla-central/annotate/a6fa09658817e99eb52335a0773f567ab20a34aa/obj-firefox/dist/include/nsIURIMutator.h#l489

I'm reasonably sure this is coming from SetUserPass in nsIURIMutator.idl.

Type: -- → defect

It's not good to let nsSimpleURI::SetUserPass return NS_OK nor remove the ENSURE_SUCCESS
We had better look at the clients of |nsIURIMutator::SetUserPass| if they expect a failure.

Here's an example to SetUserPass to an nsSimpleURI
https://searchfox.org/mozilla-central/rev/1eb05019f47069172ba81a6c108a584a409a24ea/dom/ipc/BrowserChild.cpp#3632-3639

Looking at the comment, it's an expected behavior. Hence, the warning should be removed.
Not sure if it's all of the false alarms.

This deserves some fix to avoid some error-prone behavior.

Priority: -- → P2
Whiteboard: [necko-triaged]

This removes a rather verbose warning during URI mutation. This often
happens for use cases such as attempting to clear the field. Since Finalize
is marked as MOZ_MUST_USE we can be confident that any failures that used
to be warned about are properly handled.

Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0f04e75e875
Remove verbose warning in SetUserPass. r=mayhemer
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.