Closed Bug 156936 Opened 22 years ago Closed 22 years ago

regression: crash using OBJECT tag with any plugin - M1BR Trunk [@ MSVCRT.DLL | libc.so.6 - nsPluginHostImpl::TrySetUpPluginInstance]

Categories

(Core Graveyard :: Plug-ins, defect, P1)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: peterlubczynski-bugs, Assigned: srgchrpv)

References

(
URL
)

Details

(6 keywords, Whiteboard: [adt2 rtm] [ETA 07/15] [verified-trunk])

Crash Data

Attachments

(1 file)

patch v1
1.29 KB, patch
peterlubczynski-bugs
: review+
jag+mozilla
: superreview+
chofmann
: approval+
Details | Diff | Splinter Review 
In bug 108557 there was a testcase using the OBJECT tag that now crashes in
recent builds. This is a regression from bug 152334. Serge has a fix on the way.
Attached patch patch v1 — — Splinter Review 

    
    

    
  
Comment on attachment 90979 [details] [diff] [review]
patch v1

r=peterl  great! lets get this in ASAP

        Attachment #90979 -
        Flags: review+

    
    

    
  
Adding keywords for crash on top pages and nominating for branch
Keywords: adt1.0.1, 
          
            crash, 
          
            mozilla1.0.1, 
          
            patch, 
          
            regression, 
          
            testcase, 
          
            top100, 
          
            topcrash
Priority: -- → P1
Target Milestone: --- → mozilla1.0.1

    
  
Severity: normal → blocker
Keywords: smoketest

    
    

    
  
Comment on attachment 90979 [details] [diff] [review]
patch v1

sr=jag

        Attachment #90979 -
        Flags: superreview+

    
    

    
  
timeless asked me to look at this patch for sr ... but I see jag beat me to it.

The changes look fine to me, though I'd like to know if this is a wallpaper fix
or is there a legitimate reason why the presShell doesn't have a document at the
time this is called?

-
-    rv = shell->GetDocument(aDocument);
+    if (shell)
+      rv = shell->GetDocument(aDocument);


    
    

    
  
Would this also fix bug 156782?

    
  
Whiteboard: [adt2 rtm]  [edt=7/15]

    
    

    
  
Whoops I meant under what situations would a presContext not have a presShell.

    
    

    
  
kin:
+    if (shell)
+      rv = shell->GetDocument(aDocument);
is for bug 144877, and get in this patch by mistake

jst: yes, it fixes bug 156782


    
    

    
  
*** Bug 156782 has been marked as a duplicate of this bug. ***

    
    

    
  
checked in on the trunk
mozilla/layout/html/base/src/nsObjectFrame.cpp,v  <--  nsObjectFrame.cpp
new revision: 1.353; previous revision: 1.352
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
shrir - can we get this one verified tomorrow? thanks!
Blocks: 143047
Whiteboard: [adt2 rtm]  [edt=7/15] → [adt2 rtm]  [ETA 07/15]

    
    

    
  
verified fixed on 0712 trunk. looks good, no crash.
Status: RESOLVED → VERIFIED
Keywords: testcase
Whiteboard: [adt2 rtm]  [ETA 07/15] → [adt2 rtm]  [ETA 07/15][verified-trunk]

    
    

    
  
adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
Drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.
Keywords: adt1.0.1 → adt1.0.1+
Whiteboard: [adt2 rtm]  [ETA 07/15][verified-trunk] → [adt2 rtm]  [ETA 07/15] [verified-trunk]

    
    

    
  
Comment on attachment 90979 [details] [diff] [review]
patch v1

a=chofmann for 1.0.1. add the fixed1.0.1 keyword after checking in on the
branch.

        Attachment #90979 -
        Flags: approval+

    
  
Keywords: mozilla1.0.1 → mozilla1.0.1+

    
    

    
  
patch in branch
Keywords: mozilla1.0.1+ → fixed1.0.1

    
    

    
  
verified fixed on branch 0716. looks good.
Keywords: verified1.0.1

    
    

    
  
*** Bug 157943 has been marked as a duplicate of this bug. ***

    
    

    
  
Adding M1BR Trunk [@ MSVCRT.DLL | libc.so.6 -
nsPluginHostImpl::TrySetUpPluginInstance] to summary for future reference.
Keywords: topcrash → testcase, 
          
            topcrash+
Summary: regression: crash using OBJECT tag with any plugin → regression: crash using OBJECT tag with any plugin - M1BR Trunk [@ MSVCRT.DLL | libc.so.6 - nsPluginHostImpl::TrySetUpPluginInstance]

    
    

    
  
shrir: can you pls verify this on the 1.0 branch, then replace "fixed1.0.1" with
"verified1.0.1"? thanks!

    
    

    
  
it was verified alreadyon 0716,clearing up the 'fixed101' keywd.
Keywords: fixed1.0.1
Crash Signature: [@ MSVCRT.DLL | libc.so.6 - nsPluginHostImpl::TrySetUpPluginInstance]

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: