Closed Bug 1569384 Opened 1 year ago Closed 1 year ago
GData provider icon must be square for Web Extension requirements
Same as in attachment 9081082 [details], with some stray metadata removed so it matches the original image.
Comment on attachment 9081685 [details] [diff] [review] gcal_icon_resize.patch Approved by Philipp in #maildev: [2019-07-30 13:25:43] <Fallen> rjl: it was just adding padding, right? rs+ on that
Comment on attachment 9081685 [details] [diff] [review] gcal_icon_resize.patch Adding Philipp's r+. It's 32x32 now, I checked. I guess you want that backported. If so, set the flags.
Attachment #9081685 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Assignee: rob → geoff
Attachment #9081082 - Attachment is obsolete: true
Attachment #9081685 - Attachment is obsolete: true
Attachment #9081831 - Flags: review+
Attachment #9081831 - Flags: approval-calendar-esr?(philipp)
Attachment #9081831 - Flags: approval-calendar-beta?(philipp)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/ba084f9a4b3f Repair transparent background in GData Provider icon. rs=philipp DONTBUILD
Comment on attachment 9081831 [details] [diff] [review] 1569384-transparent-icon.diff No need to uplift this, uplifting bug 1570269 instead. Looks like for a binary file it's a straight replacement regardless of what the current state is, so no need to apply the patches here.
You need to log in before you can comment on or make changes to this bug.