Closed Bug 1569384 Opened 1 year ago Closed 1 year ago

GData provider icon must be square for Web Extension requirements.

Categories

(Calendar :: Provider: GData, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: sancus, Assigned: darktrojan)

Details

Attachments

(1 file, 2 obsolete files)

Attached image gcal.png (obsolete) —

It won't upload to ATN unless the icon is square, and it's 32x29 for some reason. I padded it out with 3 pixels of height to the background, and rounded off the corners.

Attached patch gcal_icon_resize.patch (obsolete) — Splinter Review
Same as in attachment 9081082 [details], with some stray metadata removed
so it matches the original image.
Attachment #9081685 - Flags: review?(geoff)
Assignee: nobody → rob
Status: NEW → ASSIGNED
Comment on attachment 9081685 [details] [diff] [review]
gcal_icon_resize.patch

Approved by Philipp in #maildev:
[2019-07-30 13:25:43]  <Fallen> rjl: it was just adding padding, right? rs+ on that
Attachment #9081685 - Flags: review?(geoff)
Keywords: checkin-needed
Comment on attachment 9081685 [details] [diff] [review]
gcal_icon_resize.patch

Adding Philipp's r+. It's 32x32 now, I checked. I guess you want that backported. If so, set the flags.
Flags: needinfo?(rob)
Attachment #9081685 - Flags: review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e61fcbd9f549
Make gdata provider icon square (32x32) for ATN. rs=philipp

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 70

Why does the icon now have a black background?

Now with a transparent icon.

Assignee: rob → geoff
Attachment #9081082 - Attachment is obsolete: true
Attachment #9081685 - Attachment is obsolete: true
Flags: needinfo?(rob)
Attachment #9081831 - Flags: review+
Attachment #9081831 - Flags: approval-calendar-esr?(philipp)
Attachment #9081831 - Flags: approval-calendar-beta?(philipp)
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ba084f9a4b3f
Repair transparent background in GData Provider icon. rs=philipp DONTBUILD
Attachment #9081831 - Flags: approval-calendar-esr?(philipp)
Attachment #9081831 - Flags: approval-calendar-esr+
Attachment #9081831 - Flags: approval-calendar-beta?(philipp)
Attachment #9081831 - Flags: approval-calendar-beta+

You might want to push bug 1570269 down to ESR instead, I finally managed to find the original brand request.

Comment on attachment 9081831 [details] [diff] [review]
1569384-transparent-icon.diff

No need to uplift this, uplifting bug 1570269 instead. Looks like for a binary file it's a straight replacement regardless of what the current state is, so no need to apply the patches here.
Attachment #9081831 - Flags: approval-calendar-esr+
Attachment #9081831 - Flags: approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.