1569384 - GData provider icon must be square for Web Extension requirements.

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Andrei Hajdukewycz [:sancus]]

Attachment: gcal.png

It won't upload to ATN unless the icon is square, and it's 32x29 for some reason. I padded it out with 3 pixels of height to the background, and rounded off the corners.

Comment 1

[Rob Lemley [:rjl]]

Attachment: gcal_icon_resize.patch

Same as in attachment 9081082 [details], with some stray metadata removed
so it matches the original image.

Comment 2

[Rob Lemley [:rjl]]

Comment on attachment 9081685 [details] [diff] [review]
gcal_icon_resize.patch

Approved by Philipp in #maildev:
[2019-07-30 13:25:43]  <Fallen> rjl: it was just adding padding, right? rs+ on that

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9081685 [details] [diff] [review]
gcal_icon_resize.patch

Adding Philipp's r+. It's 32x32 now, I checked. I guess you want that backported. If so, set the flags.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e61fcbd9f549
Make gdata provider icon square (32x32) for ATN. rs=philipp

Comment 5

[Geoff Lankow (:darktrojan)]

Why does the icon now have a black background?

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1569384-transparent-icon.diff

Now with a transparent icon.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ba084f9a4b3f
Repair transparent background in GData Provider icon. rs=philipp DONTBUILD

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

You might want to push bug 1570269 down to ESR instead, I finally managed to find the original brand request.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9081831 [details] [diff] [review]
1569384-transparent-icon.diff

No need to uplift this, uplifting bug 1570269 instead. Looks like for a binary file it's a straight replacement regardless of what the current state is, so no need to apply the patches here.