156945 - Need to have external leading for normal Line-height

Status: RESOLVED DUPLICATE of bug 218032

(Core :: Internationalization, defect)

Description

[Shanjian Li]

In CJK text, normal line height is too small and does not looks very good. Bug
76097 is filed against windows, and there is long discussion there. This bug is
filed against linux. I would suggest to fix this problem after we found
satisfied solution for both bug 76097 and bug 156943.

Hideo saito has posted some patched in 76097, please refer that bug for detail.

Comment 1

[Yuying Long]

Is this just for line-height? cause there is another bug 110826 for underline
problem, but I'm not quite sure the patch over there is for line-height or
underline.

Comment 2

[Shanjian Li]

This is for lineheight, and that one is for underline position.

Comment 3

[Koike Kazuhiko]

Is it necessary to add mExternalLeading and mInternalLeading to
nsFontMetricsGTK like nsFontMetricsWin in bug 76097?
How about other platforms?

Comment 4

[Yuying Long]

nominate this as nsbeta1.

Comment 5

[Alexey Chernyak]

See bug 137817

Comment 6

[marina]

Yuying, is it a page view enchancement or the display is wrong?

Comment 7

[Yuying Long]

The display is not wrong but the CJK pages looks ugly without fix.  Bug 76097
and bug 15643 have some screen shots to show the problem.

Comment 8

[Samir Gehani]

i18n triage team: nsbeta1-

Comment 9

[Jungshik Shin]

Marking as resolved (dupe of bug 218032) I know this is backward, but I didn't
know the existence of this bug before filing bug 218032 and spending a lot of
time there. (I didn't read through the end of bug 76097 ;-))

*** This bug has been marked as a duplicate of 218032 ***