1569460 - Firefox 70.0a1 (2019-07-27) core::result::unwrap_failed - panic in CubebDeviceCollectionManager ::internal_register

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[drJeckyll]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Visit web.skype.com

Actual results:

Firefox crashed - https://crash-stats.mozilla.org/report/index/98fd5d2b-eb4c-4cbe-8136-8ed670190728

Expected results:

Don't crash

Comment 1

[[:philipp]]

these crashes newly showing up since nightly build 20190727093108 come with moz crash reason devcol register failed: Error { code: Error } from bug 1569090.

Comment 2

[Matthew Gregan [:kinetik]]

Thanks for the bug report. What does about:support say under Media/Audio Backend? Also, web.skype.com gives me an unsupported browser error, are you overriding the user agent string to get further or is it crashing on the unsupported browser page?

Comment 3

[drJeckyll]

I can't open about:support, because browser crashes with - https://crash-stats.mozilla.org/report/index/1080ee66-3765-4386-85d5-7fa570190729#tab-bugzilla

Yes, I override user agent, but it was working couple of days ago just fine - I mean for chat. I don't use audio/video there.

But browser crashes on aliexpress.com too - trying to login - https://crash-stats.mozilla.org/report/index/2e7ff05d-765e-45d6-83ec-e661a0190729

Comment 4

[Matthew Gregan [:kinetik]]

Thanks for the answers!

I'm not sure why cubeb_register_device_collection_changed fails on your machine. I was wondering if you're using a different audio backend, or if there's something else different about your configuration that causes it to fail.

Assuming you're using the PulseAudio backend and normal audio playback is working correctly, I'm not sure why this would fail. That's potentially a different bug we need to investigate, although the fallback handling in Gecko's CubebDeviceEnumerator means it won't actually cause problems in Gecko since we'll just re-enumerate as necessary. Before https://bugzilla.mozilla.org/show_bug.cgi?id=1569090 landed, we would've been relying on the fallback behaviour exclusively for the default (audio sandboxing on) configuration since the remoted implementation of cubeb_register_device_collection_changed was returning CUBEB_ERROR_NOT_SUPPORTED.

The fix for the immediate issue of crashing on error is up for review at: https://github.com/djg/audioipc-2/pull/71

Comment 5

[drJeckyll]

I'm not using PulseAudio. I'm using apulse on Gentoo Linux. I have no trouble to play youtube, vimeo & etc - these are working just fine.

Comment 6

[Matthew Gregan [:kinetik]]

Aha, thanks. apulse doesn't implement part of the PA API we're using for this: https://github.com/i-rinat/apulse/blob/05515f06faf3d7bd247efd4ec49d3d277cad03e4/src/apulse-context.c#L751, which explains the error from cubeb_register_device_collection_changed.

Comment 7

[drJeckyll]

/offtopic
That's was one of the reasons me and a lot of people were against dropping ALSA ... but nobody listen.

Comment 8

[Paul Adenot (:padenot)]

We can make this non-fatal, it's not the end of the world if this call does not succeed.

Edit: hrm I see that kinetik already has done just this.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

:kinetik, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 10

[Matthew Gregan [:kinetik]]

Attachment: Bug 1569460 - Update AudioIPC to f6f56c43.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd17824c618e
Update AudioIPC to f6f56c43. r=chunmin

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bd17824c618e