Closed
Bug 1569506
Opened 5 years ago
Closed 5 years ago
SamplerThread can own a Sampler instead of being one
Categories
(Core :: Gecko Profiler, task, P2)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
SamplerThread inheriting from Sampler is a bit confusing, and scary with no virtual destructor&functions.
SamplerThread only uses Sampler's Disable() and SuspendAndSampleAndResumeThread() functions, and SamplerThread is never accessed through a Sampler reference/pointer.
So SamplerThread can just own a Sampler to make that relationship clearer.
|
Assignee | |
Comment 1•5 years ago
|
||
SamplerThread inheriting from Sampler was a bit confusing, and scary with no
virtual destructor&functions.
SamplerThread only uses Sampler's Disable() and
SuspendAndSampleAndResumeThread() functions, and SamplerThread is never
accessed through a Sampler reference/pointer.
So SamplerThread can just own a Sampler to make that relationship clearer.
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/812481eb89c4 SamplerThread can own a Sampler instead of being one - r=canaltinova
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•