Closed Bug 1569506 Opened 4 months ago Closed 4 months ago

SamplerThread can own a Sampler instead of being one

Categories

(Core :: Gecko Profiler, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

SamplerThread inheriting from Sampler is a bit confusing, and scary with no virtual destructor&functions.
SamplerThread only uses Sampler's Disable() and SuspendAndSampleAndResumeThread() functions, and SamplerThread is never accessed through a Sampler reference/pointer.
So SamplerThread can just own a Sampler to make that relationship clearer.

SamplerThread inheriting from Sampler was a bit confusing, and scary with no
virtual destructor&functions.
SamplerThread only uses Sampler's Disable() and
SuspendAndSampleAndResumeThread() functions, and SamplerThread is never
accessed through a Sampler reference/pointer.
So SamplerThread can just own a Sampler to make that relationship clearer.

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/812481eb89c4
SamplerThread can own a Sampler instead of being one - r=canaltinova
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.