1569506 - SamplerThread can own a Sampler instead of being one

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

SamplerThread inheriting from Sampler is a bit confusing, and scary with no virtual destructor&functions.
SamplerThread only uses Sampler's Disable() and SuspendAndSampleAndResumeThread() functions, and SamplerThread is never accessed through a Sampler reference/pointer.
So SamplerThread can just own a Sampler to make that relationship clearer.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1569506 - SamplerThread can own a Sampler instead of being one - r?canaltinova

SamplerThread inheriting from Sampler was a bit confusing, and scary with no
virtual destructor&functions.
SamplerThread only uses Sampler's Disable() and
SuspendAndSampleAndResumeThread() functions, and SamplerThread is never
accessed through a Sampler reference/pointer.
So SamplerThread can just own a Sampler to make that relationship clearer.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/812481eb89c4
SamplerThread can own a Sampler instead of being one - r=canaltinova

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/812481eb89c4