1569569 - Refactor HUDService to make it specific to the browser console

Status: RESOLVED FIXED

(DevTools :: Console, task, P3)

Description

[Alexandre Poirot [:ochameau]]

HUDService is mostly being used for the Browser Console.
Outside of the browser console usecase, it is only used by WebConsolePanel in order to instanciate the WebConsole object.
https://searchfox.org/mozilla-central/source/devtools/client/webconsole/panel.js#71
Which later forces us to manually remove the WebConsole reference from HUDService internal map over here:
https://searchfox.org/mozilla-central/source/devtools/client/webconsole/webconsole.js#381

We don't need this Map:
https://searchfox.org/mozilla-central/source/devtools/client/webconsole/hudservice.js#37
Instead, HUDService could be focused on managing the WebConsole singleton used for the Browser console. And WebConsolePanel would self-manage its WebConsole object.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

When doing this, the architecture diagram in console-panel.md should be updated

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Are you currently working on this Alex? You're assigned to it but the Status is NEW. if you're not, I'll take it.

Comment 3

[Alexandre Poirot [:ochameau]]

Yes, didn't I submitted the patch for review?!

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1569569 - Stop returning self from WebConsole.init.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1569569 - Instantiates WebConsole directly from WebConsolePanel.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1569569 - Make HUDService specific to the browser console.

Comment 7

[Alexandre Poirot [:ochameau]]

Sorry about that, I forgot to ask for submit the patches to phabricator. I rebased the patches against latest m-c.
And a new try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e4c0b8dd82b760cb2fe0aeb432e7b550d5dbb70

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ddb38c03e4e
Stop returning self from WebConsole.init. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/82d6d3db3918
Instantiates WebConsole directly from WebConsolePanel. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/3d68ad734f21
Make HUDService specific to the browser console. r=nchevobbe

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5ddb38c03e4e
https://hg.mozilla.org/mozilla-central/rev/82d6d3db3918
https://hg.mozilla.org/mozilla-central/rev/3d68ad734f21