Closed Bug 1569620 Opened 3 months ago Closed 2 months ago

Discuss use of color icons in the FxA toolbar menu

Categories

(Firefox :: Firefox Accounts, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: vbudhram, Assigned: vbudhram)

References

Details

(Whiteboard: [fxa])

Attachments

(1 file, 1 obsolete file)

Hey all,

Just wanted to capture the discussion and outcomes from the product demo last week. Outstanding questions were:

  • Should we use color icons for the new Firefox Account services?
  • Should we have a subview panel for these services?
    • Only subview for no signed in user?

Depends on D40049

Assignee: nobody → vbudhram

From discussions, the FxA toolbar menu was updated with the following

  • Use color icons for service logos
  • Removed sub panel views on clicking service
  • Moved up the Sync Now button

Ref https://mozilla.invisionapp.com/share/V6ST9IFJMXP#/screens/372045396_Skyline_FxA_Toolbar

Keywords: checkin-needed

Hi Vijay. Which patches need to be landed? the stack lands D40103 and D40049.

Flags: needinfo?(vbudhram)

Hey :apavel,

Sorry about the confusion. D40049 should land first and then this. I'll hold off on putting the checked-in flag until D40049 gets lands and sticks.

Flags: needinfo?(vbudhram)

D4009 has landed, so this can be checked in now.

Keywords: checkin-needed
Depends on: 1562006

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/d365e6ff7382
Update Fxa toolbar menu to latest skyline ux designs r=markh

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

This bug removes the panel landed in bug 1562006, but not the strings. Is there a reason? Are those strings going to be still used elsewhere?

Flags: needinfo?(vbudhram)
Depends on: 1573035

Hey :flod

Nope, they are not reused anymore. I'll submit a patch removing them. Thanks for catching this!

Flags: needinfo?(vbudhram)

Comment on attachment 9085552 [details]
Bug 1569620 - Remove unused FxA toolbar menu strings

Revision D42017 was moved to bug 1573946. Setting attachment 9085552 [details] to obsolete.

Attachment #9085552 - Attachment is obsolete: true
Depends on: 1584076
You need to log in before you can comment on or make changes to this bug.