Closed Bug 1569676 Opened 4 years ago Closed 4 years ago

Convert most panel destroy methods to be synchronous

Tracking

(firefox70 fixed)

Status:

RESOLVED FIXED

Milestone:

Firefox 70

Tracking Flags:

Tracking

Status

firefox70

---

fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(8 files)

Bug 1569676 - Make accessibility panel's destroy synchronous. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1569676 - Make DOM and application panel's destroy synchronous. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1569676 - Make memory panel's destroy synchronous. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1569676 - Make new performance panel's destroy synchronous. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1569676 - Make scratchpad destroy synchronous. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1569676 - Make storage panel's destroy synchronous. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1569676 - Make style editor panel's destroy synchronous. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1569676 - Wait for toolbox to be loaded before closing the toolbox in browser_toolbox_toolbar_reorder_with_secondary_toolbox.js. 4 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review

Alexandre Poirot [:ochameau]

Assignee

Description

•

4 years ago

See bug 1529621. This other bug dependencies are covering the most important tools like console and inspector. This bug is going to cover most of the other tools left.

After that, there should only be the old performance panel to be converted, bug 1569675.
Then, all panel.destroy methods are going to be synchronous.

Alexandre Poirot [:ochameau]

Assignee

Comment 1

•

4 years ago

Attached file Bug 1569676 - Make accessibility panel's destroy synchronous. — Details

Alexandre Poirot [:ochameau]

Assignee

Comment 2

•

4 years ago

Attached file Bug 1569676 - Make DOM and application panel's destroy synchronous. — Details

Alexandre Poirot [:ochameau]

Assignee

Comment 3

•

4 years ago

Attached file Bug 1569676 - Make memory panel's destroy synchronous. — Details

The memory actor is a target scoped one and they are all destroyed
when the toolbox closes. So memory actor's destroy method is called.
It then calls bridge's destroy, which also detach the actor if it was
attached.

Alexandre Poirot [:ochameau]

Assignee

Comment 4

•

4 years ago

Attached file Bug 1569676 - Make new performance panel's destroy synchronous. — Details

Alexandre Poirot [:ochameau]

Assignee

Comment 5

•

4 years ago

Attached file Bug 1569676 - Make scratchpad destroy synchronous. — Details

Alexandre Poirot [:ochameau]

Assignee

Comment 6

•

4 years ago

Attached file Bug 1569676 - Make storage panel's destroy synchronous. — Details

Alexandre Poirot [:ochameau]

Assignee

Comment 7

•

4 years ago

Attached file Bug 1569676 - Make style editor panel's destroy synchronous. — Details

Alexandre Poirot [:ochameau]

Assignee

Comment 8

•

4 years ago

Attached file Bug 1569676 - Wait for toolbox to be loaded before closing the toolbox in browser_toolbox_toolbar_reorder_with_secondary_toolbox.js. — Details

A RDP request is made during toolbox opening and this request isn't awaited for
during the call to gDevTools.showToolbox. This relates to the autohide menu.
Await for this request to be finished and the DOM elements relating to it to be disabled
before trying to close the toolbox.

Patrick Brosset <:pbro>

Updated

•

4 years ago

Priority: -- → P3

Pulsebot

Comment 9

•

4 years ago

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/996c40dbc9e2
Make accessibility panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/8365fc01396b
Make DOM and application panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/5227c89295f4
Make memory panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/1bc927ef181a
Make new performance panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/c0b0e0410a66
Make scratchpad destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/59660e3e2e53
Make storage panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/2dab5e2243d0
Make style editor panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/997ad11003a3
Wait for toolbox to be loaded before closing the toolbox in browser_toolbox_toolbar_reorder_with_secondary_toolbox.js. r=jdescottes

Bogdan Tara[:bogdan_tara | bogdant]

Comment 10

•

4 years ago

Backed out 8 changesets (Bug 1569676) for failures on browser_toolbox_tool_ready.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=devtools-chrome-e10s&fromchange=1870efc7be2bfca7a0e1fd821df5d54a36d6e6ca&tochange=8437b860258fe0a83da254761f7c8f5b221f7116&selectedJob=259971620

Backout link: https://hg.mozilla.org/integration/autoland/rev/8437b860258fe0a83da254761f7c8f5b221f7116

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259971620&repo=autoland&lineNumber=1606

[task 2019-08-05T18:29:25.554Z] 18:29:25 [task 2019-08-05T18:29:26.143Z] 18:29:26 [task 2019-08-05T18:29:26.173Z] 18:29:26 [task 2019-08-05T18:29:26.250Z] 18:29:26 [task 2019-08-05T18:29:26.251Z] 18:29:26 [task 2019-08-05T18:29:29.240Z] 18:29:29 [task 2019-08-05T18:29:29.240Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.418Z] 18:29:29 [task 2019-08-05T18:29:29.420Z] 18:29:29 [task 2019-08-05T18:29:29.420Z] 18:29:29 [task 2019-08-05T18:29:29.422Z] 18:29:29 [task 2019-08-05T18:29:29.423Z] 18:29:29 [task 2019-08-05T18:29:29.423Z] 18:29:29 [task 2019-08-05T18:29:29.423Z] 18:29:29 [task 2019-08-05T18:29:29.423Z] 18:29:29 [task 2019-08-05T18:29:29.434Z] 18:29:29 [task 2019-08-05T18:29:29.434Z] 18:29:29 [task 2019-08-05T18:29:29.434Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.436Z] 18:29:29 [task 2019-08-05T18:29:29.437Z] 18:29:29 [task 2019-08-05T18:29:29.437Z] 18:29:29 [task 2019-08-05T18:29:29.437Z] 18:29:29 [task 2019-08-05T18:29:29.437Z] 18:29:29 [task 2019-08-05T18:29:29.437Z] 18:29:29 [task 2019-08-05T18:29:29.438Z] 18:29:29 [task 2019-08-05T18:29:29.438Z] 18:29:29 [task 2019-08-05T18:29:29.438Z] 18:29:29 [task 2019-08-05T18:29:29.438Z] 18:29:29 [task 2019-08-05T18:29:29.439Z] 18:29:29 [task 2019-08-05T18:29:29.439Z] 18:29:29 [task 2019-08-05T18:29:29.439Z] 18:29:29 [task 2019-08-05T18:29:29.439Z] 18:29:29 [task 2019-08-05T18:29:29.439Z] 18:29:29 [task 2019-08-05T18:29:29.440Z] 18:29:29 [task 2019-08-05T18:29:29.440Z] 18:29:29 [task 2019-08-05T18:29:29.440Z] 18:29:29 [task 2019-08-05T18:29:29.440Z] 18:29:29 [task 2019-08-05T18:29:29.440Z] 18:29:29 [task 2019-08-05T18:29:29.440Z] 18:29:29 [task 2019-08-05T18:29:29.441Z] 18:29:29 [task 2019-08-05T18:29:29.441Z] 18:29:29 [task 2019-08-05T18:29:29.441Z] 18:29:29 [task 2019-08-05T18:29:29.441Z] 18:29:29 [task 2019-08-05T18:29:29.442Z] 18:29:29 [task 2019-08-05T18:29:29.442Z] 18:29:29 [task 2019-08-05T18:29:29.442Z] 18:29:29 [task 2019-08-05T18:29:29.443Z] 18:29:29 [task 2019-08-05T18:29:29.443Z] 18:29:29 [task 2019-08-05T18:29:29.443Z] 18:29:29 [task 2019-08-05T18:29:29.443Z] 18:29:29 [task 2019-08-05T18:29:29.443Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.444Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 [task 2019-08-05T18:29:29.445Z] 18:29:29 INFO - TEST-START | devtools/client/framework/test/browser_toolbox_tool_ready.js
INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
INFO - GECKO(1632) | JavaScript error: , line 0: uncaught exception: Object
INFO - TEST-INFO | started process screencapture
INFO - TEST-INFO | screencapture: exit 0
INFO - Buffered messages logged at 18:29:25
INFO - Adding a new tab with URL: about:blank
INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 112}]
INFO - Tab added and finished loading
INFO - About to open 0/options
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for options -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be options -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | options panel should be ready -
INFO - About to open 1/inspector
INFO - Buffered messages logged at 18:29:26
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for inspector -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be inspector -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | inspector panel should be ready -
INFO - About to open 2/webconsole
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for webconsole -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be webconsole -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | webconsole panel should be ready -
INFO - About to open 3/jsdebugger
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for jsdebugger -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be jsdebugger -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | jsdebugger panel should be ready -
INFO - About to open 4/netmonitor
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for netmonitor -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be netmonitor -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | netmonitor panel should be ready -
INFO - About to open 5/styleeditor
INFO - Buffered messages logged at 18:29:27
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for styleeditor -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be styleeditor -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | styleeditor panel should be ready -
INFO - About to open 6/performance
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for performance -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be performance -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | performance panel should be ready -
INFO - About to open 7/memory
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for memory -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be memory -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | memory panel should be ready -
INFO - About to open 8/storage
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for storage -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be storage -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | storage panel should be ready -
INFO - About to open 9/accessibility
INFO - Console message: [JavaScript Warning: "XUL box for vbox element contained an inline label child, forcing all its children to be wrapped in a block." {file: "chrome://devtools/content/storage/index.xul" line: 0}]
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for accessibility -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be accessibility -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | accessibility panel should be ready -
INFO - About to open 10/application
INFO - Buffered messages logged at 18:29:28
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for application -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be application -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | application panel should be ready -
INFO - About to open 11/dom
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for dom -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be dom -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | dom panel should be ready -
INFO - About to open 12/scratchpad
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | toolbox exists for scratchpad -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | currentToolId should be scratchpad -
INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | scratchpad panel should be ready -
INFO - Buffered messages logged at 18:29:29
INFO - Console message: [JavaScript Warning: "XUL box for toolbar element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://devtools/content/shared/sourceeditor/codemirror/codemirror.bundle.js" line: 1}]
INFO - Console message: [JavaScript Warning: "XUL box for toolbar element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.js" line: 1297}]
INFO - Console message: While creating services from category 'speech-synth-started', could not create service for entry 'OSX Speech Synth', contract ID '@mozilla.org/synthsystem;1'
INFO - Console message: [JavaScript Warning: "onmozfullscreenchange is deprecated." {file: "about:blank" line: 0}]
INFO - Console message: [JavaScript Warning: "onmozfullscreenerror is deprecated." {file: "about:blank" line: 0}]
INFO - Buffered messages finished
INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_tool_ready.js | A promise chain failed to handle a rejection: 'prototypeAndProperties' active request packet to 'server0.conn98.child1/obj39' can't be sent as the connection just closed. - stack: (No stack available.)
INFO - Rejection date: Mon Aug 05 2019 18:29:29 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 263
INFO - Stack trace:
INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:263
INFO - chrome://mochikit/content/browser-test.js:nextTest:908
INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1728
INFO - chrome://mochikit/content/browser-test.js:run:1643
INFO - GECKO(1632) | MEMORY STAT | vsize 8375MB | residentFast 1012MB | heapAllocated 221MB
INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_tool_ready.js | took 3699ms

Flags: needinfo?(poirot.alex)

Bogdan Tara[:bogdan_tara | bogdant]

Comment 11

•

4 years ago

Also seeing failures on browser_toolbox_tool_remote_reopen.js

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259970050&repo=autoland&lineNumber=7592

[task 2019-08-05T18:29:29.446Z] 18:29:29 INFO - TEST-START | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js
[task 2019-08-05T18:29:30.047Z] 18:29:30 INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2019-08-05T18:29:30.082Z] 18:29:30 INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2019-08-05T18:29:30.116Z] 18:29:30 INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2019-08-05T18:29:30.116Z] 18:29:30 INFO - GECKO(1632) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2019-08-05T18:29:32.960Z] 18:29:32 INFO - GECKO(1632) | JavaScript error: , line 0: uncaught exception: Object
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Buffered messages logged at 18:29:29
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Adding a new tab with URL: about:blank
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 112}]
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Tab added and finished loading
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - About to open 0/options
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Version: 2.1 INTEL-12.9.22
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Vendor: Intel Inc.
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Renderer: Intel Iris OpenGL Engine
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - FBO Texture Target: TEXTURE_2D
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for options -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be options -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | options panel should be ready -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - About to open 1/inspector
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - Buffered messages logged at 18:29:30
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for inspector -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be inspector -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | inspector panel should be ready -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - About to open 2/webconsole
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for webconsole -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be webconsole -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | webconsole panel should be ready -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - About to open 3/jsdebugger
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for jsdebugger -
[task 2019-08-05T18:29:32.970Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be jsdebugger -
[task 2019-08-05T18:29:32.971Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | jsdebugger panel should be ready -
[task 2019-08-05T18:29:32.971Z] 18:29:32 INFO - About to open 4/netmonitor
[task 2019-08-05T18:29:32.973Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for netmonitor -
[task 2019-08-05T18:29:32.973Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be netmonitor -
[task 2019-08-05T18:29:32.973Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | netmonitor panel should be ready -
[task 2019-08-05T18:29:32.975Z] 18:29:32 INFO - About to open 5/styleeditor
[task 2019-08-05T18:29:32.975Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for styleeditor -
[task 2019-08-05T18:29:32.975Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be styleeditor -
[task 2019-08-05T18:29:32.975Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | styleeditor panel should be ready -
[task 2019-08-05T18:29:32.975Z] 18:29:32 INFO - About to open 6/performance
[task 2019-08-05T18:29:32.975Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for performance -
[task 2019-08-05T18:29:32.975Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be performance -
[task 2019-08-05T18:29:32.979Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | performance panel should be ready -
[task 2019-08-05T18:29:32.979Z] 18:29:32 INFO - About to open 7/memory
[task 2019-08-05T18:29:32.979Z] 18:29:32 INFO - Buffered messages logged at 18:29:31
[task 2019-08-05T18:29:32.979Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for memory -
[task 2019-08-05T18:29:32.979Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be memory -
[task 2019-08-05T18:29:32.980Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | memory panel should be ready -
[task 2019-08-05T18:29:32.980Z] 18:29:32 INFO - About to open 8/storage
[task 2019-08-05T18:29:32.980Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for storage -
[task 2019-08-05T18:29:32.980Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be storage -
[task 2019-08-05T18:29:32.980Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | storage panel should be ready -
[task 2019-08-05T18:29:32.980Z] 18:29:32 INFO - About to open 9/accessibility
[task 2019-08-05T18:29:32.981Z] 18:29:32 INFO - Console message: [JavaScript Warning: "XUL box for vbox element contained an inline label child, forcing all its children to be wrapped in a block." {file: "chrome://devtools/content/storage/index.xul" line: 0}]
[task 2019-08-05T18:29:32.981Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for accessibility -
[task 2019-08-05T18:29:32.981Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be accessibility -
[task 2019-08-05T18:29:32.981Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | accessibility panel should be ready -
[task 2019-08-05T18:29:32.981Z] 18:29:32 INFO - About to open 10/application
[task 2019-08-05T18:29:32.981Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for application -
[task 2019-08-05T18:29:32.982Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be application -
[task 2019-08-05T18:29:32.982Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | application panel should be ready -
[task 2019-08-05T18:29:32.982Z] 18:29:32 INFO - About to open 11/dom
[task 2019-08-05T18:29:32.982Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for dom -
[task 2019-08-05T18:29:32.987Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be dom -
[task 2019-08-05T18:29:32.987Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | dom panel should be ready -
[task 2019-08-05T18:29:32.987Z] 18:29:32 INFO - About to open 12/scratchpad
[task 2019-08-05T18:29:32.987Z] 18:29:32 INFO - Buffered messages logged at 18:29:32
[task 2019-08-05T18:29:32.987Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | toolbox exists for scratchpad -
[task 2019-08-05T18:29:32.987Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | currentToolId should be scratchpad -
[task 2019-08-05T18:29:32.987Z] 18:29:32 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | scratchpad panel should be ready -
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - Console message: [JavaScript Warning: "XUL box for toolbar element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://devtools/content/shared/sourceeditor/codemirror/codemirror.bundle.js" line: 1}]
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - Console message: [JavaScript Warning: "XUL box for toolbar element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://devtools/content/scratchpad/index.xul" line: 0}]
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - Console message: [JavaScript Warning: "onmozfullscreenchange is deprecated." {file: "about:blank" line: 0}]
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - Console message: [JavaScript Warning: "onmozfullscreenerror is deprecated." {file: "about:blank" line: 0}]
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - Buffered messages finished
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | A promise chain failed to handle a rejection: 'prototypeAndProperties' active request packet to 'server0.conn99.child1/obj39' can't be sent as the connection just closed. - stack: (No stack available.)
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - Rejection date: Mon Aug 05 2019 18:29:32 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 263
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - Stack trace:
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:263
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - chrome://mochikit/content/browser-test.js:nextTest:908
[task 2019-08-05T18:29:32.988Z] 18:29:32 INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1728
[task 2019-08-05T18:29:32.989Z] 18:29:32 INFO - chrome://mochikit/content/browser-test.js:run:1643
[task 2019-08-05T18:29:32.989Z] 18:29:32 INFO - GECKO(1632) | MEMORY STAT | vsize 8370MB | residentFast 1016MB | heapAllocated 237MB
[task 2019-08-05T18:29:32.989Z] 18:29:32 INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js | took 3622ms

Alexandre Poirot [:ochameau]

Assignee

Comment 12

•

4 years ago

It should be fixed now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18b88f98cc9aae625fa0c899bffa38ea4061a143

Flags: needinfo?(poirot.alex)

Pulsebot

Comment 13

•

4 years ago

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37bd619b82a9
Make accessibility panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/2b3e0300ef3b
Make DOM and application panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/f5373b558e6f
Make memory panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/b30344f638f8
Make new performance panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/0548d159a75e
Make scratchpad destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/41f4ddd45b45
Make storage panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/87c9fe6c03f1
Make style editor panel's destroy synchronous. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/b22b74e628da
Wait for toolbox to be loaded before closing the toolbox in browser_toolbox_toolbar_reorder_with_secondary_toolbox.js. r=jdescottes

Alexandru Michis [:malexandru]

Comment 14

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/37bd619b82a9
https://hg.mozilla.org/mozilla-central/rev/2b3e0300ef3b
https://hg.mozilla.org/mozilla-central/rev/f5373b558e6f
https://hg.mozilla.org/mozilla-central/rev/b30344f638f8
https://hg.mozilla.org/mozilla-central/rev/0548d159a75e
https://hg.mozilla.org/mozilla-central/rev/41f4ddd45b45
https://hg.mozilla.org/mozilla-central/rev/87c9fe6c03f1
https://hg.mozilla.org/mozilla-central/rev/b22b74e628da

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox70: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 70

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

Convert most panel destroy methods to be synchronous

Categories

(DevTools :: General, enhancement, P3)

Tracking

(firefox70 fixed)

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(8 files)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6

Comment 7

Comment 8

Updated

Comment 9

Comment 10

Comment 11

Comment 12

Comment 13

Comment 14