Closed Bug 1569707 Opened 8 months ago Closed 8 months ago

[mozdevice] - Improve boot complete detection and ensure that the device state is reset after rebooting

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bc, Assigned: bc)

Details

Attachments

(1 file)

While investigating Bug 1504757, I found during standalone testing of adb.py that ADBDevice.reboot() does not automatically reset selinux back to permissive. We can improve the situation by introducing new internal methods for checking boot state and setting the root and selinux state during initialization and after rebooting.

Add internal method _wait_for_bootcompleted to wait until sys.boot_completed and dev.bootcomplate are set.
Add internal method _initialize_boot_state to encapsulate the steps required to initialize device state.
Make sure to set device state after rebooting.
Normalize optional arguments for _test_path calls.
Add verbose logging for shell_bool.

mozdevice 3.0.3
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=187ca1f618c6872b39866d4c8645bac90fb3b3f3

There were a number of ADBTimeoutErrors in the bitbar script which were due to Bug 1569459 / Bug 1525373

There was also one instance of ADBDevice.init: ls could not be found however it was in the bitbar script as well which did not have the updated version of mozdevice. Once this passes review, we can publish mozdevice 3.0.3 and deploy to bitbar.

Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f37f48a9d92
[mozdevice 3.0.3] - Improve boot complete detection and ensure that the device state is reset after rebooting, r=gbrown.
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.