Closed
Bug 1569731
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 18157 - Fix timeout in payment-is-showing.https.html
Categories
(Core :: DOM: Web Payments, task, P4)
Core
DOM: Web Payments
Tracking
()
RESOLVED
FIXED
mozilla70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 18157 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/18157
Details from upstream follow.
Danyao Wang <danyao@google.com> wrote:
Fix timeout in payment-is-showing.https.html
The changed test was timing out before because of three reasons:
- The onload event of the popup never fired after navigation.
- The test assumed that
popupShowPromise
would reject when the popup navigates. This is not true in all implementations (i.e. Chrome) and this behavior has been removed from the spec. See https://github.com/w3c/payment-request/issues/872- This test file contains many test cases that use
test_driver.bless()
. When run from the web-based runner, the human tester may not be able to click through all steps within the default timeout of 1 minute.(1) is fixed by adding an onload handler to the popup page, though I don't fully understand why.
(2) is fixed by replacing the
promise_rejects
expectation with astep_timeout
to check that a new payment sheet can be opened successfully. This is sufficient to verify that the old payment sheet was indeed closed.(3) is fixed by increasing the timeout by adding
<meta name="timeout" content="long">
.
Assignee | ||
Updated•5 years ago
|
Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=662ccbed24ac617e048004a3a1f26e8562d56bc2
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3c946495ec747666db9abc17f744226ec91a8b5
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fcf808d708ab2d7e5401b916d4db2a81139c009
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f85aff119c2c1788cbd5e774df60802a64491997
Assignee | ||
Comment 5•5 years ago
|
||
Ran 1 tests Tests that are disabled for instability: /payment-request/payment-is-showing.https.html
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b419ad61115 [wpt PR 18157] - Fix timeout in payment-is-showing.https.html, a=testonly
Comment 7•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•