Closed Bug 1569731 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 18157 - Fix timeout in payment-is-showing.https.html

Categories

(Core :: DOM: Web Payments, task, P4)

Product:
Core
Component:
DOM: Web Payments
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18157 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18157
Details from upstream follow.

Danyao Wang <danyao@google.com> wrote:

Fix timeout in payment-is-showing.https.html

The changed test was timing out before because of three reasons:

  1. The onload event of the popup never fired after navigation.
  2. The test assumed that popupShowPromise would reject when the popup navigates. This is not true in all implementations (i.e. Chrome) and this behavior has been removed from the spec. See https://github.com/w3c/payment-request/issues/872
  3. This test file contains many test cases that use test_driver.bless(). When run from the web-based runner, the human tester may not be able to click through all steps within the default timeout of 1 minute.

(1) is fixed by adding an onload handler to the popup page, though I don't fully understand why.

(2) is fixed by replacing the promise_rejects expectation with a step_timeout to check that a new payment sheet can be opened successfully. This is sufficient to verify that the old payment sheet was indeed closed.

(3) is fixed by increasing the timeout by adding <meta name="timeout" content="long">.

Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core
Ran 1 tests Tests that are disabled for instability: /payment-request/payment-is-showing.https.html
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b419ad61115 [wpt PR 18157] - Fix timeout in payment-is-showing.https.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5b419ad61115

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.