1569747 - Stack upload with changed reviewer fails

Status: RESOLVED DUPLICATE of bug 1569785

(Conduit :: moz-phab, defect)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

A previously submitted (with no reviewers, for feedback) patch was updated locally to add a reviewer, then submitted as part of a large stack.

Expected Behaviour:

Stack is submitted, reviewer is set

Actual behaviour:

543742:d3419a423c0a Bug 1567579 - Defer allocation of LazyScript to after parsing r?tcampbell
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 SKIP STAGING  Phabricator does not support staging areas for this repository.
Updated an existing Differential revision:
        Revision URI: https://phabricator.services.mozilla.com/D38699

Included changes:
  M       js/src/frontend/BinASTParserPerTokenizer.h
  M       js/src/frontend/BytecodeCompiler.cpp
  M       js/src/frontend/ParseContext.cpp
  M       js/src/frontend/ParseContext.h
  M       js/src/frontend/Parser.cpp
  M       js/src/frontend/Parser.h
  M       js/src/frontend/SharedContext.h
  M       js/src/vm/JSScript.h
ERR-CONDUIT-CORE: Validation errors:
  - You can not request review of this revision because this revision is already under review and the action would have no effect.

and stack upload stopped there.

If I'm reading it right, It sounds like this was supposed to be fixed in Bug 1531627, but I'm not having luck with it.

At time of writing, my moz-phab is up to date.

update: I was also particularly surprised to discover that the revision -was indeed updated- after the angry message.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Notably this left my tree in an ugly state:

o  543752:67cad9dff4fa mgaudet tip Bug 1567579 - Store inner functionboxes instead of inner functions r?tcampbell
| *  543751:dfce1799d969 mgaudet Bug 1569315 - Defer mainline function allocations until after parse r?tcampbell
| *  543749:b34cddf558cb mgaudet Bug 1569315 - Defer function allocation for field initializers r?tcampbell
| *  543748:ff7822496510 mgaudet Bug 1569315 - Defer allocation of JSFunction for synthesizeConstructor in parser r?tcampbell
| *  543747:9a4dd612dc06 mgaudet Bug 1569315 - Create FunctionFlags class to allow recycling function flag queries elsewhere r?tcampbell
| *  543746:3537517fa32c mgaudet Bug 1569315 - Factor FunctionCreationData into its own header r?tcampbell
| *  543745:5aa5d37dfb54 mgaudet Bug 1569315 - Factor out FunctionCreationData from AllocNewFunction r?tcampbell
| *  543744:863d8db25440 mgaudet Bug 1569315 - Sink prototype fetching into AllocNewFunction r?tcampbell
| *  543743:cdbdf576a4fa mgaudet Bug 1569315 - Add visitor system to FunctionTree r?tcampbell
| @  543742:d3419a423c0a mgaudet Bug 1567579 - Defer allocation of LazyScript to after parsing r?tcampbell
| x  543741:99cbb5d835b9 mgaudet Bug 1567579 - Store inner functionboxes instead of inner functions r?tcampbell
|/
o  543697:5471875b3452 mgaudet Bug 1567579 - Set the toStringEnd on the lazyScript directly during construction. r?tcampbell

Where 543752:67cad9dff4fa was successfully submitted, and 543742:d3419a423c0a was the failed attempt to upload.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Another thing: It's not clear what the right course of action is from this message: should I set the reviewer on phabricator? If I do that, will I be able to update the revision again?