Closed Bug 1569749 Opened 5 years ago Closed 5 years ago

Update spellcheck context menu

Categories

(SeaMonkey :: General, enhancement)

Product:
SeaMonkey
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.67
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.63 --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(4 files)

Port bug 905176
6.03 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Port bug 908570
3.06 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Port bug 1071771
1.42 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Port bug 1026099
7.98 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Port following bugs:

  • Bug 905176 - Don't show the Check Spelling menu item for spellcheck=false contenteditable elements
  • Bug 908570 - Don't show the 'Add Dictionaries…' menu item for contenteditable elements with spellcheck=false
  • Bug 1071771 - disable dictionary list when it cannot be accessed from another process. This makes the context menu work again after using it on a misspelled word
  • Bug 1026099 - Rework the spellchecker context menu to not use CPOWs
Attached patch Port bug 905176 — — Splinter Review

Also matches showUndo to the definition in Firefox's nsContextMenu.js

Attached patch Port bug 908570 — — Splinter Review
Attached patch Port bug 1071771 — — Splinter Review
Attached patch Port bug 1026099 — — Splinter Review
Attachment #9081498 - Flags: review?(frgrahl)
Attachment #9081379 - Flags: review?(frgrahl)
Attachment #9081382 - Flags: review?(frgrahl)
Attachment #9081384 - Flags: review?(frgrahl)
Comment on attachment 9081384 [details] [diff] [review]
Port bug 1071771

Looks good 1:1 port
Attachment #9081384 - Flags: review?(frgrahl)
Attachment #9081384 - Flags: review+
Attachment #9081384 - Flags: approval-comm-release+
Attachment #9081384 - Flags: approval-comm-esr60+
Comment on attachment 9081379 [details] [diff] [review]
Port bug 905176

> suite/base/content/nsContextMenu.js
> +    var editable = aNode.isContentEditable;

Seems to be a let now in m-c. The others could probably also be changed. Depending on the age of the original patch var or let is it. If not needed in a global scope I usually use let these days.

r/a+ either way.
Attachment #9081379 - Flags: review?(frgrahl)
Attachment #9081379 - Flags: review+
Attachment #9081379 - Flags: approval-comm-release+
Attachment #9081379 - Flags: approval-comm-esr60+
Comment on attachment 9081382 [details] [diff] [review]
Port bug 908570

Looks good to me
Attachment #9081382 - Flags: review?(frgrahl)
Attachment #9081382 - Flags: review+
Attachment #9081382 - Flags: approval-comm-release+
Attachment #9081382 - Flags: approval-comm-esr60+
Comment on attachment 9081498 [details] [diff] [review]
Port bug 1026099

Looks good. Bug 1345081 might be a candidate for later backporting.
Attachment #9081498 - Flags: review?(frgrahl)
Attachment #9081498 - Flags: review+
Attachment #9081498 - Flags: approval-comm-release+
Attachment #9081498 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/fbf1e3f22422
Update spellcheck context menu. Port Bug 905176 "Don't show the Check Spelling menu item for spellcheck=false contenteditable elements". r=frg
https://hg.mozilla.org/comm-central/rev/7adfef34879e
Update spellcheck context menu - Port Bug 908570 "Don't show the 'Add Dictionaries...' menu item for contenteditable elements with spellcheck=false". r=frg
https://hg.mozilla.org/comm-central/rev/83dc96d6de55
Update spellcheck context menu - Port Bug 1071771 "disable dictionary list when it cannot be accessed from another process". r=frg
https://hg.mozilla.org/comm-central/rev/9fb74899b806
Update spellcheck context menu - Port Bug 1026099 "Rework the spellchecker context menu to not use CPOWs". r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/ba8a0b4d4c71
Update spellcheck context menu - Remove double import from bad rebasse. rs=me

https://hg.mozilla.org/releases/comm-esr60/rev/6809d06a5b834fe052308762dca91a275816ae8d
Bug 1569749 - Update spellcheck context menu. Port Bug 905176 "Don't show the Check Spelling menu item for spellcheck=false contenteditable elements". r=frg a=frg
https://hg.mozilla.org/releases/comm-esr60/rev/a73b3a81a817f34e124aed51433f7f4a98664574
Bug 1569749 - Update spellcheck context menu - Port Bug 908570 "Don't show the 'Add Dictionaries...' menu item for contenteditable elements with spellcheck=false". r=frg a=frg
https://hg.mozilla.org/releases/comm-esr60/rev/fefca2976fee13e40bc01466a3f24fba76c28ad2
Bug 1569749 - Update spellcheck context menu - Port Bug 1071771 "disable dictionary list when it cannot be accessed from another process". r=frg a=frg
https://hg.mozilla.org/releases/comm-esr60/rev/d40072488eaea90bd58f1336f0b32d2a0e228730
Bug 1569749 - Update spellcheck context menu - Port Bug 1026099 "Rework the spellchecker context menu to not use CPOWs". r=frg a=frg

status-seamonkey2.49esr: --- → wontfix
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → fixed
status-seamonkey2.63: --- → wontfix
Target Milestone: --- → seamonkey2.67
Version: unspecified → Trunk
status-seamonkey2.53: affected → fixed
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: