Closed Bug 1569772 Opened 4 months ago Closed 4 months ago

Crash in [@ mozilla::ipc::MessageChannel::CxxStackFrame::CxxStackFrame | mozilla::ipc::MessageChannel::Send | mozilla::net::PNeckoChild::SendRemoveRequestContext]

Categories

(Core :: Networking, defect, P2, critical)

69 Branch
Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: philipp, Assigned: junior)

Details

(Keywords: crash, regression, Whiteboard: [necko-triaged])

Crash Data

Attachments

(1 file)

This bug is for crash report bp-072b6696-05db-4bf7-9964-db16c0190720.

Top 10 frames of crashing thread:

0 xul.dll mozilla::ipc::MessageChannel::CxxStackFrame::CxxStackFrame ipc/glue/MessageChannel.cpp:225
1 xul.dll mozilla::ipc::MessageChannel::Send ipc/glue/MessageChannel.cpp:980
2 xul.dll mozilla::net::PNeckoChild::SendRemoveRequestContext ipc/ipdl/PNeckoChild.cpp:1933
3 xul.dll mozilla::net::RequestContextService::RemoveRequestContext netwerk/base/RequestContextService.cpp:562
4 xul.dll mozilla::net::nsLoadGroup::~nsLoadGroup netwerk/base/nsLoadGroup.cpp:107
5 xul.dll void mozilla::net::nsLoadGroup::~nsLoadGroup netwerk/base/nsLoadGroup.cpp:100
6 xul.dll mozilla::net::nsLoadGroup::Release netwerk/base/nsLoadGroup.cpp:116
7 xul.dll void nsIconChannel::~nsIconChannel image/decoders/icon/win/nsIconChannel.cpp:173
8 xul.dll nsresult nsIconChannel::IconAsyncOpenTask::Run image/decoders/icon/win/nsIconChannel.cpp:104
9 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225

content crash reports with this signature are regressing (again) in firefox 69 from windows machines. they come with MOZ_RELEASE_ASSERT(mWorkerThread == GetCurrentVirtualThread()) (not on worker thread!) and users who opted to submit the crashing url appear to have been browsing some local directory structures through the file:///-protocol mostly.

Assignee: nobody → juhsu
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by juhsu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31c85754cf94
Release load group on main thread in win/nsIconChannel r=tnikkel
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Fix is looking good on Nightly so far. Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(juhsu)

Comment on attachment 9081472 [details]
Bug 1569772 - Release load group on main thread in win/nsIconChannel

Beta/Release Uplift Approval Request

  • User impact if declined: More crashes
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Have same approach here and there
  • String changes made/needed:
Flags: needinfo?(juhsu)
Attachment #9081472 - Flags: approval-mozilla-beta?

Comment on attachment 9081472 [details]
Bug 1569772 - Release load group on main thread in win/nsIconChannel

Small crash fix. Approved for 69.0b10.

Attachment #9081472 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.