1569785 - Adding a reviewer to a request without a reviewer errors with "You can not request review of this revision…"

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Matthew N. [:MattN]]

In the last two weeks or so adding a reviewer to a commit message with no existing reviewer causes an error:

ERR-CONDUIT-CORE: Validation errors:

• You can not request review of this revision because this revision is already under review and the action would have no effect.

STR:

1. Submit a commit for review without WIP but without reviewers
2. Make changes and add a reviewer to the commit e.g r=foo

Expected result:

• Review is requested from "foo"
• Commit is updated

Actual result:

• Error from above
• Review isn't requested

I'm guessing this could have been regressed by bug 1564166 but I didn't confirm.

Comment 2

[Piotr Zalewa [:zalun]]

I can't replicate by trying:

phab@2d4b47fcd729:~/test-repo$ echo e > A
phab@2d4b47fcd729:~/test-repo$ hg commit -m E
phab@2d4b47fcd729:~/test-repo$ moz-phab -b 1
...
phab@2d4b47fcd729:~/test-repo$ moz-phab -r ConduitReviewer
...
Completed
(D9) 5:7db9c7e29448 Bug 1 - E r=ConduitReviewer
-> http://phabricator.test/D9

Could you provide the logs from ~/.mozbuild/moz-phab/moz-phab.log

Comment 3

[Matthew N. [:MattN]]

Attachment: moz-phab.log

(In reply to Piotr Zalewa [:zalun] from comment #2)

phab@2d4b47fcd729:~/test-repo$ moz-phab -r ConduitReviewer

I have never used the -r argument. As I said in my step 2, I updated the commit message to add "r=sfoster"

Could you provide the logs from ~/.mozbuild/moz-phab/moz-phab.log

Attached

Comment 4

[Piotr Zalewa [:zalun]]

I still can't replicate, but removing the request to review when a revision is in a needs-review state is sane.

Comment 5

[Piotr Zalewa [:zalun]]

Attachment: Bug 1569785 - Do not request the review if revision is in `needs-review` status.