1569877 - [Inactive CSS] Wrong warning about height and display on textarea elements.

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Patrick Brosset <:pbro>]

• Open data:text/html,<textarea style="height: 300px">test</textarea>
• See a 300px tall <textarea> element.
• Open devtools, inspect the <textarea>
• See how it claims the height property has no effect, but it does.

Textareas are inline by default, but they are considered replaced elements, so the height and width properties do apply.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1569877 - Consider textarea as a replaced element; r?miker!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99003d5e05c8
Consider textarea as a replaced element; r=miker

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/99003d5e05c8

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 9081586 [details]
Bug 1569877 - Consider textarea as a replaced element; r?miker!

Beta/Release Uplift Approval Request

• User impact if declined: This is a follow-up to bug 1565652 that was already uplifted to beta 69.
  In that bug we missed one case that should really have been fixed at the same time.
  Let me copy the rationale for uplifting this:

Inactive CSS is a new DevTools feature we are planning on shipping to all our users with Firefox 69.
It is undergoing QA validation in beta 69 right now.
This bug was identified recently and impacts negatively the user experience for this new feature.
If we do not uplift this bug fix, some users of the Inspector panel in DevTools might be shown incorrect information as to when their CSS code is valid or not.
This will have negative impact on the confidence they have in the feature and may not want to use it afterwards.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is not risky because the code change is very small and contained to just the Rule-View sidebar of the Inspector panel in DevTools.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9081586 [details]
Bug 1569877 - Consider textarea as a replaced element; r?miker!

Follow-up fix for bug 1565652 with an automated test included. Approved for 69.0b10.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ba385b3664a

Comment 7

[Cristian Fogel [:cfogel]]

Confirmed issue with 69.0b8.
Fix verified with 69.0b10, 70.0a1 (2019-08-04).