Closed Bug 1569877 Opened 4 months ago Closed 4 months ago

[Inactive CSS] Wrong warning about height and display on textarea elements.

Categories

(DevTools :: Inspector: Rules, defect, P2)

defect

Tracking

(firefox69 verified, firefox70 verified)

VERIFIED FIXED
Firefox 70
Tracking Status
firefox69 --- verified
firefox70 --- verified

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

  • Open data:text/html,<textarea style="height: 300px">test</textarea>
  • See a 300px tall <textarea> element.
  • Open devtools, inspect the <textarea>
  • See how it claims the height property has no effect, but it does.

Textareas are inline by default, but they are considered replaced elements, so the height and width properties do apply.

Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99003d5e05c8
Consider textarea as a replaced element; r=miker
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Comment on attachment 9081586 [details]
Bug 1569877 - Consider textarea as a replaced element; r?miker!

Beta/Release Uplift Approval Request

  • User impact if declined: This is a follow-up to bug 1565652 that was already uplifted to beta 69.
    In that bug we missed one case that should really have been fixed at the same time.
    Let me copy the rationale for uplifting this:

Inactive CSS is a new DevTools feature we are planning on shipping to all our users with Firefox 69.
It is undergoing QA validation in beta 69 right now.
This bug was identified recently and impacts negatively the user experience for this new feature.
If we do not uplift this bug fix, some users of the Inspector panel in DevTools might be shown incorrect information as to when their CSS code is valid or not.
This will have negative impact on the confidence they have in the feature and may not want to use it afterwards.

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It is not risky because the code change is very small and contained to just the Rule-View sidebar of the Inspector panel in DevTools.
  • String changes made/needed:
Attachment #9081586 - Flags: approval-mozilla-beta?
Flags: in-testsuite+

Comment on attachment 9081586 [details]
Bug 1569877 - Consider textarea as a replaced element; r?miker!

Follow-up fix for bug 1565652 with an automated test included. Approved for 69.0b10.

Attachment #9081586 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Confirmed issue with 69.0b8.
Fix verified with 69.0b10, 70.0a1 (2019-08-04).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.