1569897 - FormAutoFill still leaks if the focused input is removed before closing the browser

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Julian Descottes [:jdescottes]]

The fix I am landing in https://bugzilla.mozilla.org/show_bug.cgi?id=1566870 is not fixing all the leaks that we have with FormAutoFill in devtools.

This fix relies on receiving a focusout (blur) event to cleanup references on FormAutofillContent.jsm. However if the input is removed before being blurred, this event will never be received and we will still have a leak.

I now believe we should simply avoid keeping any non-weak reference on DOM elements in FormAutofillContent, rather than trying to add various hooks to cleanup the state.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1569897 - Only keep weak references on the active element from FormAutofillContent

Depends on D39716

Comment 2

[Matthew N. [:MattN]]

I think it would be good to have QA do a quick check that address autofill still works once this is resolved in case the test coverage misses something.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23956b86e0b6
Only keep weak references on the active element from FormAutofillContent r=MattN

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/23956b86e0b6

Comment 5

[Brendan Dahl [:bdahl]]

Saw an error in the console JavaScript error: chrome://formautofill/content/FormAutofillFrameScript.js, line 86: Error: Unexpected event type focusout

Shouldn't we also remove https://searchfox.org/mozilla-central/rev/29cce9a2684ef64c4f1f996087da8b7545d31f65/browser/extensions/formautofill/content/FormAutofillFrameScript.js#63

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to Brendan Dahl [:bdahl] from comment #5)

Saw an error in the console JavaScript error: chrome://formautofill/content/FormAutofillFrameScript.js, line 86: Error: Unexpected event type focusout

Shouldn't we also remove https://searchfox.org/mozilla-central/rev/29cce9a2684ef64c4f1f996087da8b7545d31f65/browser/extensions/formautofill/content/FormAutofillFrameScript.js#63

Good catch! Filed Bug 1570885 to fix it.

Comment 7

[Peter Magyari (Desktop QA)]

Hi,

I've verified that the address autofill still works as expected after the fix using Firefox Nightly 70.0a1(20190730215316).