1569915 - getAddonByID is not a function

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect, P3)

Description

[vtol]

• W10 Pro x_64 v1903 b18362.267
• Tb 69.0b1 (64-bit) en-GB

---

error console

TypeError: AddonManager.getAddonByID is not a functionpreferences.js:162:52

would appear to the be generated by chrome://messenger/content/preferences/preferences.js

let lastFallbackInstalled = await AddonManager.getAddonByID(lastFallbackId);

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1569915-preferences-addomManager.patch

I don't see this error and I don't know how to reproduce it. But it must be the missing AddonManager.jsm.

The same for beta and ESR.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9081747 [details] [diff] [review]
1569915-preferences-addomManager.patch

Why don't we just import it? Like so:
var { AddonManager } = ChromeUtils.import("resource://gre/modules/AddonManager.jsm");

I'm not the right guy for this review.

Comment 3

[Richard Marti (:Paenglab)]

FX does it also this way: https://searchfox.org/mozilla-central/source/browser/components/preferences/in-content/preferences.js#22

Comment 4

[vtol]

n/a to Nightly 70?

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9081747 [details] [diff] [review]
1569915-preferences-addomManager.patch

The problem's [here](https://searchfox.org/comm-central/rev/2610dbf889d5edf81108b5ca511c1caad7df1595/mail/components/preferences/preferences.js#154) but I don't know enough about the locale service to trigger it. I'm fairly sure this patch will fix it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0ba96d275d8a
Add AddonManager.jsm to preferences.js. r=darktrojan

Comment 7

[Jorg K (CEST = GMT+2)]

TB 69 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/96b2c9a52bb8c7299f81bed600e90694d7eaa2f4

Comment 8

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/520a34c5a2b44f3827f44493396beca68f831e7b