Closed Bug 1569915 Opened 2 months ago Closed 2 months ago

getAddonByID is not a function

Categories

(Thunderbird :: Add-Ons: General, defect, P3)

x86_64
Windows 10
defect

Tracking

(thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird_esr68 68+ fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: vtol, Assigned: Paenglab)

Details

Attachments

(1 file)

  • W10 Pro x_64 v1903 b18362.267
  • Tb 69.0b1 (64-bit) en-GB

error console

TypeError: AddonManager.getAddonByID is not a functionpreferences.js:162:52

would appear to the be generated by chrome://messenger/content/preferences/preferences.js

let lastFallbackInstalled = await AddonManager.getAddonByID(lastFallbackId);

I don't see this error and I don't know how to reproduce it. But it must be the missing AddonManager.jsm.

The same for beta and ESR.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9081747 - Flags: review?(jorgk)
Attachment #9081747 - Flags: approval-comm-esr68?
Attachment #9081747 - Flags: approval-comm-beta?
Comment on attachment 9081747 [details] [diff] [review]
1569915-preferences-addomManager.patch

Why don't we just import it? Like so:
var { AddonManager } = ChromeUtils.import("resource://gre/modules/AddonManager.jsm");

I'm not the right guy for this review.
Attachment #9081747 - Flags: review?(jorgk) → review?(geoff)

n/a to Nightly 70?

Comment on attachment 9081747 [details] [diff] [review]
1569915-preferences-addomManager.patch

The problem's [here](https://searchfox.org/comm-central/rev/2610dbf889d5edf81108b5ca511c1caad7df1595/mail/components/preferences/preferences.js#154) but I don't know enough about the locale service to trigger it. I'm fairly sure this patch will fix it.
Attachment #9081747 - Flags: review?(geoff) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0ba96d275d8a
Add AddonManager.jsm to preferences.js. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
Attachment #9081747 - Flags: approval-comm-esr68?
Attachment #9081747 - Flags: approval-comm-esr68+
Attachment #9081747 - Flags: approval-comm-beta?
Attachment #9081747 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.