1569969 - wrong URL in list of sources in debugger

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[Standa David]

Attachment: bug.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Logged in to admin on https://www.journal-theme.com/1/admin/index.php with login demo password demo
Every logged in user has its own user token in GET parameter in URL
Then I oppened developer tool, debugger tab and there in list of sources are files without GET parameters so they are usable to debug.

Actual results:

Every file in list does not have any GET parameters

Expected results:

Every file in list should have GET parameters

Comment 1

[Jason Laster [:jlast]]

This was intentional because the params can be noisy. We have a tooltip which shows the full path on firefox 69, which will be available soon.

Comment 2

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:jlast, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Standa David]

(In reply to Jason Laster [:jlast] from comment #1)

This was intentional because the params can be noisy. We have a tooltip which shows the full path on firefox 69, which will be available soon.

and it was even intentional that source code in debugger matches to URL !WITHOUT! parameters so it is unable to debug any dynamic page based on parameters?
For me it looks like P1 in the debugger because it is not usable

Comment 4

[:Harald Kirschner :digitarald]

Standa, I might not understand correctly. In this case there are no other index.php, so its clear which file is being debugging. Could you describe the issue you are running into that makes debugging impossible?

Comment 5

[Standa David]

(In reply to :Harald Kirschner :digitarald from comment #4)

Standa, I might not understand correctly. In this case there are no other index.php, so its clear which file is being debugging. Could you describe the issue you are running into that makes debugging impossible?

I made investigation, what is wrong, because get parameters are preserved but HTML code is different in debugger and in inspector. I made very simple PHP test page:
https://os6.standa-david.com/bugzilla.php?title=text

I am attaching more images

Comment 6

[Standa David]

Problem is in not preserving session_id. Cookies must be different in inspector and in debugger view

Comment 7

[Standa David]

Attachment: inspector view

Comment 8

[Standa David]

Attachment: Debugger view

same page - just switched to debugger tab.

Comment 9

[Jason Laster [:jlast]]

brian, this looks like a source requests related issue.

Comment 10

[Brian Hackett [Laid off!]]

Generally, we should always show the correct HTML contents when the devtools are already open when a page is being loaded or reloaded. It seems like that expected behavior is what is happening here, though it's not clear what the expected results with comment 0 should be. When the devtools are opened after the page has loaded and we refetch incorrect HTML, what we should do is show the JS sources themselves instead of that incorrect HTML, which is bug 1582266.