Closed Bug 1570082 Opened 5 months ago Closed 5 months ago

Convert VarCache prefs in nsContentSink to static prefs

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: KrisWright, Assigned: KrisWright)

References

(Blocks 1 open bug)

Details

Attachments

(10 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

There are 12 VarCache prefs in nsContentSink:
https://searchfox.org/mozilla-central/rev/1eb05019f47069172ba81a6c108a584a409a24ea/dom/base/nsContentSink.cpp#152

These could be converted to static prefs, and the nsContentSink::InitializeStatics() function removed.

Converts content.notify.ontimer varcache pref to static pref. Also adds a new pref group, 'content'.

Converts content.notify.backoffcount varcache pref to static pref.

Converts content.notify.interval varcache pref to a static pref. Rewords the description, which referenced 'gNotificationInterval' which no longer existed.

Converts the varcache prefs 'content.sink.interactive_deflect_count' and 'content.sink.perf_deflect_count' to static prefs.

Converts VarCache pref content.sink.pending_event_mode to a static pref and removes the all.js value. Since the value in all.js is only set in the ifndef XP_WIN condition, the pref favors that value only as needed.

Converts content.sink.event_probe_rate to a static pref.

Converts varcache prefs content.sink.interactive_parse_time and content.sink.perf_parse_time to static prefs.

Converts varcache pref content.sink.interactive_time to a static pref.

Converts content.sink.initial_perf_time to a static pref.

Converts content.sink.enable_perf_mode to a static pref. Also removes nsContentSink::InitializeStatics(), since this is the last varcache pref in the function.

Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21ce1e54336e
Convert content.notify.ontimer to static pref and add content group to prefs groups. r=njn
https://hg.mozilla.org/integration/autoland/rev/aa357b98b000
Convert content.notify.backoffcount to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/539968cf5dca
Convert content.notify.interval to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/79d998cb4496
Convert content.sink.*_deflect_count to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/40a19c762054
Convert content.sink.pending_event_mode to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/992dd86ab7b2
Convert content.sink.event_probe_rate to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/422f02308048
Convert content.sink.*_parse_time to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/9208b59e5620
Convert content.sink.interactive_time to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/f881852d88b9
Convert content.sink.initial_perf_time to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/185c1089ef45
Convert content.sink.enable_perf_mode to static pref r=njn
Assignee: nobody → kwright
You need to log in before you can comment on or make changes to this bug.